Re: [PATCH] hfsplus: Add module parameter to enable force writes

Matthew Wilcox
2022-12-02T21:02:24Z

On Fri, Dec 02, 2022 at 12:53:44PM -0800, Andrew Morton wrote:
> > + if (force_journaled_rw) {
> > + pr_warn("write access to a journaled filesystem is not supported, but has been force enabled.\n");
> > + } else {
> > + pr_warn("write access to a journaled filesystem is not supported, use the force option at your own risk, mounting read-only.\n");
> > + sb->s_flags |= SB_RDONLY;
> > + }
>
> All these super long lines are an eyesore. How about
>
> pr_warn("write access to a journaled filesystem is "
> "not supported, but has been force enabled.\n");

Linus has asked us to not do that because it makes it hard to grep.