Re: [PATCH v2] hfsplus: Add module parameter to enable force writes

Matthew Wilcox
2022-12-06T15:19:51Z

On Sun, Dec 04, 2022 at 06:43:43AM +0000, Aditya Garg wrote:
>
>
> > On 04-Dec-2022, at 6:35 AM, kernel test robot <lkp@intel.com> wrote:
> >
> > Hi Aditya,
> >
> > Thank you for the patch! Perhaps something to improve:
> >
> > [auto build test WARNING on akpm-mm/mm-everything]
> > [also build test WARNING on linus/master v6.1-rc7 next-20221202]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Aditya-Garg/hfsplus-Add-module-parameter-to-enable-force-writes/20221203-151143
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> > patch link: https://lore.kernel.org/r/79C58B25-8ECF-432B-AE90-2194921DB797%40live.com
> > patch subject: [PATCH v2] hfsplus: Add module parameter to enable force writes
> > reproduce:
> > # https://github.com/intel-lab-lkp/linux/commit/dfb483e3c16e562d768f9bddc63252f1cccb0275
> > git remote add linux-review https://github.com/intel-lab-lkp/linux
> > git fetch --no-tags linux-review Aditya-Garg/hfsplus-Add-module-parameter-to-enable-force-writes/20221203-151143
> > git checkout dfb483e3c16e562d768f9bddc63252f1cccb0275
> > make menuconfig
> > # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS
> > make htmldocs
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> >>> Documentation/filesystems/hfsplus.rst:65: WARNING: Unexpected indentation.
> >
>
> Do I need to fix this or should I consider it as a false positive?

Your patch creates the warning, so yes you need to fix it.