Re: [PATCH v5 1/5] dt-bindings: clock: Add SM8550 TCSR CC clocks

Abel Vesa
2022-12-06T21:06:03Z

On 22-12-06 16:35:16, Krzysztof Kozlowski wrote:
> On 06/12/2022 13:56, Abel Vesa wrote:
> > Add bindings documentation for clock TCSR driver on SM8550.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > .../bindings/clock/qcom,sm8550-tcsr.yaml | 53 +++++++++++++++++++
> > include/dt-bindings/clock/qcom,sm8550-tcsr.h | 18 +++++++
> > 2 files changed, 71 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm8550-tcsr.yaml
> > create mode 100644 include/dt-bindings/clock/qcom,sm8550-tcsr.h
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsr.yaml
> > new file mode 100644
> > index 000000000000..15176b0457d1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsr.yaml
> > @@ -0,0 +1,53 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/qcom,sm8550-tcsr.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm TCSR Clock Controller on SM8550
> > +
> > +maintainers:
> > + - Bjorn Andersson <andersson@kernel.org>
> > +
> > +description: |
> > + Qualcomm TCSR clock control module provides the clocks, resets and
> > + power domains on SM8550
> > +
> > + See also:: include/dt-bindings/clock/qcom,sm8550-tcsr.h
> > +
> > +properties:
> > + compatible:
> > + const: qcom,sm8550-tcsr
>
> This still misses syscon. Did you send it before we talk on IRC?

Oups, I forgot to squash that part in.

Will send a new version.

>
> Best regards,
> Krzysztof
>