* [PATCH] i2c: mux: Convert to use sysfs_emit_at() API
@ 2022-12-06 11:36 ye.xingchen
2022-12-06 14:34 ` Peter Rosin
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2022-12-06 11:36 UTC (permalink / raw)
To: wsa+renesas; +Cc: peda, linux-i2c, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/i2c/muxes/i2c-demux-pinctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c
index f7a7405d4350..6dc23aedcaed 100644
--- a/drivers/i2c/muxes/i2c-demux-pinctrl.c
+++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c
@@ -167,7 +167,7 @@ static ssize_t available_masters_show(struct device *dev,
int count = 0, i;
for (i = 0; i < priv->num_chan && count < PAGE_SIZE; i++)
- count += scnprintf(buf + count, PAGE_SIZE - count, "%d:%pOF%c",
+ count += sysfs_emit_at(buf, count, "%d:%pOF%c",
i, priv->chan[i].parent_np,
i == priv->num_chan - 1 ? '\n' : ' ');
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: mux: Convert to use sysfs_emit_at() API
2022-12-06 11:36 [PATCH] i2c: mux: Convert to use sysfs_emit_at() API ye.xingchen
@ 2022-12-06 14:34 ` Peter Rosin
0 siblings, 0 replies; 2+ messages in thread
From: Peter Rosin @ 2022-12-06 14:34 UTC (permalink / raw)
To: ye.xingchen, wsa+renesas; +Cc: linux-i2c, linux-kernel
Hi!
2022-12-06 at 12:36, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/i2c/muxes/i2c-demux-pinctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c
> index f7a7405d4350..6dc23aedcaed 100644
> --- a/drivers/i2c/muxes/i2c-demux-pinctrl.c
> +++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c
> @@ -167,7 +167,7 @@ static ssize_t available_masters_show(struct device *dev,
> int count = 0, i;
>
> for (i = 0; i < priv->num_chan && count < PAGE_SIZE; i++)
> - count += scnprintf(buf + count, PAGE_SIZE - count, "%d:%pOF%c",
> + count += sysfs_emit_at(buf, count, "%d:%pOF%c",
> i, priv->chan[i].parent_np,
> i == priv->num_chan - 1 ? '\n' : ' ');
>
You need to adjust the indentation of the two follow-up lines.
Cheers,
Peter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-06 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-06 11:36 [PATCH] i2c: mux: Convert to use sysfs_emit_at() API ye.xingchen
2022-12-06 14:34 ` Peter Rosin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox