From: <ye.xingchen@zte.com.cn>
To: <andriy.shevchenko@linux.intel.com>, <jic23@kernel.org>
Cc: <lars@metafoo.de>, <u.kleine-koenig@pengutronix.de>,
<petrm@nvidia.com>, <olteanv@gmail.com>,
<ddrokosov@sberdevices.ru>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] iio: bma180: Convert to use sysfs_emit_at() API
Date: Wed, 7 Dec 2022 10:03:19 +0800 (CST) [thread overview]
Message-ID: <202212071003192805636@zte.com.cn> (raw)
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/iio/accel/bma180.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index eb697eeb4301..9e3e5dfdded7 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -488,8 +488,7 @@ static ssize_t bma180_show_avail(char *buf, const int *vals, unsigned int n,
for (i = 0; i < n; i++) {
if (!vals[i])
continue;
- len += scnprintf(buf + len, PAGE_SIZE - len,
- micros ? "0.%06d " : "%d ", vals[i]);
+ len += sysfs_emit_at(buf, len, micros ? "0.%06d " : "%d ", vals[i]);
}
buf[len - 1] = '\n';
--
2.25.1
next reply other threads:[~2022-12-07 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 2:03 ye.xingchen [this message]
2022-12-07 9:56 ` [PATCH] iio: bma180: Convert to use sysfs_emit_at() API Dmitry Rokosov
2022-12-11 12:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212071003192805636@zte.com.cn \
--to=ye.xingchen@zte.com.cn \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ddrokosov@sberdevices.ru \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=petrm@nvidia.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox