public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: <ye.xingchen@zte.com.cn>
To: <andriy.shevchenko@linux.intel.com>
Cc: <jic23@kernel.org>, <lars@metafoo.de>,
	<u.kleine-koenig@pengutronix.de>, <gwendal@chromium.org>,
	<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] iio: light: tsl2772: Convert to use sysfs_emit()/sysfs_emit_at() APIs
Date: Wed, 7 Dec 2022 15:46:47 +0800 (CST)	[thread overview]
Message-ID: <202212071546472332762@zte.com.cn> (raw)

From: ye xingchen <ye.xingchen@zte.com.cn>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/iio/light/tsl2772.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
index ad50baa0202c..03cae6a536b4 100644
--- a/drivers/iio/light/tsl2772.c
+++ b/drivers/iio/light/tsl2772.c
@@ -927,7 +927,7 @@ static ssize_t in_illuminance0_target_input_show(struct device *dev,
 {
 	struct tsl2772_chip *chip = iio_priv(dev_to_iio_dev(dev));

-	return scnprintf(buf, PAGE_SIZE, "%d\n", chip->settings.als_cal_target);
+	return sysfs_emit(buf, "%d\n", chip->settings.als_cal_target);
 }

 static ssize_t in_illuminance0_target_input_store(struct device *dev,
@@ -981,9 +981,9 @@ static ssize_t in_illuminance0_lux_table_show(struct device *dev,
 	int offset = 0;

 	while (i < TSL2772_MAX_LUX_TABLE_SIZE) {
-		offset += scnprintf(buf + offset, PAGE_SIZE - offset, "%u,%u,",
-			chip->tsl2772_device_lux[i].ch0,
-			chip->tsl2772_device_lux[i].ch1);
+		offset += sysfs_emit_at(buf, offset, "%u,%u,",
+					chip->tsl2772_device_lux[i].ch0,
+					chip->tsl2772_device_lux[i].ch1);
 		if (chip->tsl2772_device_lux[i].ch0 == 0) {
 			/*
 			 * We just printed the first "0" entry.
@@ -995,7 +995,7 @@ static ssize_t in_illuminance0_lux_table_show(struct device *dev,
 		i++;
 	}

-	offset += scnprintf(buf + offset, PAGE_SIZE - offset, "\n");
+	offset += sysfs_emit_at(buf, offset, "\n");
 	return offset;
 }

-- 
2.25.1

                 reply	other threads:[~2022-12-07  7:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202212071546472332762@zte.com.cn \
    --to=ye.xingchen@zte.com.cn \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox