From: <ye.xingchen@zte.com.cn>
To: <andriy.shevchenko@linux.intel.com>
Cc: <jic23@kernel.org>, <lars@metafoo.de>,
<u.kleine-koenig@pengutronix.de>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] iio: light: zopt2201: Convert to use sysfs_emit_at() API
Date: Wed, 7 Dec 2022 15:48:09 +0800 (CST) [thread overview]
Message-ID: <202212071548094732807@zte.com.cn> (raw)
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/iio/light/zopt2201.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/light/zopt2201.c b/drivers/iio/light/zopt2201.c
index e3bac8b56380..97e5412d3a4e 100644
--- a/drivers/iio/light/zopt2201.c
+++ b/drivers/iio/light/zopt2201.c
@@ -438,8 +438,7 @@ static ssize_t zopt2201_show_int_time_available(struct device *dev,
int i;
for (i = 0; i < ARRAY_SIZE(zopt2201_resolution); i++)
- len += scnprintf(buf + len, PAGE_SIZE - len, "0.%06lu ",
- zopt2201_resolution[i].us);
+ len += sysfs_emit_at(buf, len, "0.%06lu ", zopt2201_resolution[i].us);
buf[len - 1] = '\n';
return len;
@@ -455,9 +454,9 @@ static ssize_t zopt2201_show_als_scale_avail(struct device *dev,
int i;
for (i = 0; i < ARRAY_SIZE(zopt2201_scale_als); i++)
- len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06u ",
- zopt2201_scale_als[i].scale,
- zopt2201_scale_als[i].uscale);
+ len += sysfs_emit_at(buf, len, "%d.%06u ",
+ zopt2201_scale_als[i].scale,
+ zopt2201_scale_als[i].uscale);
buf[len - 1] = '\n';
return len;
@@ -471,9 +470,9 @@ static ssize_t zopt2201_show_uvb_scale_avail(struct device *dev,
int i;
for (i = 0; i < ARRAY_SIZE(zopt2201_scale_uvb); i++)
- len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06u ",
- zopt2201_scale_uvb[i].scale,
- zopt2201_scale_uvb[i].uscale);
+ len += sysfs_emit_at(buf, len, "%d.%06u ",
+ zopt2201_scale_uvb[i].scale,
+ zopt2201_scale_uvb[i].uscale);
buf[len - 1] = '\n';
return len;
--
2.25.1
reply other threads:[~2022-12-07 7:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212071548094732807@zte.com.cn \
--to=ye.xingchen@zte.com.cn \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox