From: <ye.xingchen@zte.com.cn>
To: <andy.shevchenko@gmail.com>
Cc: <jic23@kernel.org>, <lars@metafoo.de>, <linmq006@gmail.com>,
<u.kleine-koenig@pengutronix.de>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] iio: magnetometer: bmc150_magn: Convert to use sysfs_emit_at() API
Date: Wed, 7 Dec 2022 15:49:34 +0800 (CST) [thread overview]
Message-ID: <202212071549349412843@zte.com.cn> (raw)
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/iio/magnetometer/bmc150_magn.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
index 06d5a1ef1fbd..1398684a7f30 100644
--- a/drivers/iio/magnetometer/bmc150_magn.c
+++ b/drivers/iio/magnetometer/bmc150_magn.c
@@ -598,8 +598,7 @@ static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev,
for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) {
if (bmc150_magn_samp_freq_table[i].freq > data->max_odr)
break;
- len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
- bmc150_magn_samp_freq_table[i].freq);
+ len += sysfs_emit_at(buf, len, "%d ", bmc150_magn_samp_freq_table[i].freq);
}
/* replace last space with a newline */
buf[len - 1] = '\n';
--
2.25.1
next reply other threads:[~2022-12-07 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 7:49 ye.xingchen [this message]
2022-12-07 8:46 ` [PATCH] iio: magnetometer: bmc150_magn: Convert to use sysfs_emit_at() API Andy Shevchenko
2022-12-11 12:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212071549349412843@zte.com.cn \
--to=ye.xingchen@zte.com.cn \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linmq006@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox