From: <ye.xingchen@zte.com.cn>
To: <andy.shevchenko@gmail.com>
Cc: <jic23@kernel.org>, <lars@metafoo.de>, <jiangjian@cdjrlc.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] iio: magnetometer: hmc5843: Convert to use sysfs_emit_at() API
Date: Wed, 7 Dec 2022 15:51:01 +0800 (CST) [thread overview]
Message-ID: <202212071551017192888@zte.com.cn> (raw)
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/iio/magnetometer/hmc5843_core.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c
index c5521d61da29..134f6045e24a 100644
--- a/drivers/iio/magnetometer/hmc5843_core.c
+++ b/drivers/iio/magnetometer/hmc5843_core.c
@@ -274,9 +274,9 @@ ssize_t hmc5843_show_samp_freq_avail(struct device *dev,
int i;
for (i = 0; i < data->variant->n_regval_to_samp_freq; i++)
- len += scnprintf(buf + len, PAGE_SIZE - len,
- "%d.%d ", data->variant->regval_to_samp_freq[i][0],
- data->variant->regval_to_samp_freq[i][1]);
+ len += sysfs_emit_at(buf, len, "%d.%d ",
+ data->variant->regval_to_samp_freq[i][0],
+ data->variant->regval_to_samp_freq[i][1]);
/* replace trailing space by newline */
buf[len - 1] = '\n';
@@ -335,8 +335,7 @@ static ssize_t hmc5843_show_scale_avail(struct device *dev,
int i;
for (i = 0; i < data->variant->n_regval_to_nanoscale; i++)
- len += scnprintf(buf + len, PAGE_SIZE - len,
- "0.%09d ", data->variant->regval_to_nanoscale[i]);
+ len += sysfs_emit_at(buf, len, "0.%09d ", data->variant->regval_to_nanoscale[i]);
/* replace trailing space by newline */
buf[len - 1] = '\n';
--
2.25.1
next reply other threads:[~2022-12-07 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 7:51 ye.xingchen [this message]
2022-12-07 8:45 ` [PATCH] iio: magnetometer: hmc5843: Convert to use sysfs_emit_at() API Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212071551017192888@zte.com.cn \
--to=ye.xingchen@zte.com.cn \
--cc=andy.shevchenko@gmail.com \
--cc=jiangjian@cdjrlc.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox