Re: [PATCH v5 net-next 1/5] net/ethtool: add netlink interface for the PLCA RS

Piergiorgio Beruto
2022-12-11T11:43:18Z

On Sun, Dec 11, 2022 at 12:12:23PM +0100, Andrew Lunn wrote:
> > Given what I just said, what would you suggest to do?
>
> I would return just the version part, not the whole register contents.
>
> The nice thing about netlink is you can add extra attributes without
> breaking the ABI. If that 0xA ever gains a meaning and more values, an
> attribute for it can be added.
TBFH, this time I cannot say I fully agree with that. However, if this
is something you require to approve the changes, would you like me to
change the attribute VERSION down to an u8 or just masking the 0x0A?

Thanks,
Piergiorgio