From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5218EC63705 for ; Wed, 7 Dec 2022 21:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbiLGVth (ORCPT ); Wed, 7 Dec 2022 16:49:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbiLGVtR (ORCPT ); Wed, 7 Dec 2022 16:49:17 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF0BE84DE4; Wed, 7 Dec 2022 13:48:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0CE5B8216E; Wed, 7 Dec 2022 21:48:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74030C433D7; Wed, 7 Dec 2022 21:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670449734; bh=5dCNbmox6waUeuX2Iir4OK5SdTorc7GU4B8l9qRHQWQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=vIYh4Har7Mb8hxyOkjyXUxLcj2ioKv8LNilKJqHb2rNIcREFqI9CBb5Ya5smNOJ0S Bn7Y/u6vdr+V5UAGtGXPRS73IBztInR4k7P+hdWcejUTpZPNk2/qyxOklRkxKpS18Y gIR9qEYDgN8JtNkPOc2N+yRdxBAqNmW8LNNkRuU7vqGopEwRuTN0HUYN/qlq7QuWAI 2hwc7Nzg2f7CbnvSF0AGs8BS6xOsg4lrAjafBp7c2SAcdjMFEpC29lN+hzlSv2FwEN 48yYrCbRgAknQg7VqPpEq7mfcMSC2DK/FZ+Dxjcq12G8ek1AzuizNfEepN91Kjb4vx Kv2apagmDsBYA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221018-clk-rate-request-tracing-v2-2-5170b363c413@cerno.tech> References: <20221018-clk-rate-request-tracing-v2-0-5170b363c413@cerno.tech> <20221018-clk-rate-request-tracing-v2-2-5170b363c413@cerno.tech> Subject: Re: [PATCH v2 2/2] clk: Add trace events for rate requests From: Stephen Boyd Cc: Maxime Ripard , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org To: Masami Hiramatsu , Michael Turquette , Steven Rostedt , maxime@cerno.tech Date: Wed, 07 Dec 2022 13:48:52 -0800 User-Agent: alot/0.10 Message-Id: <20221207214854.74030C433D7@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting maxime@cerno.tech (2022-10-26 06:46:59) > It is currently fairly difficult to follow what clk_rate_request are > issued, and how they have been modified once done. >=20 > Indeed, there's multiple paths that can be taken, some functions are > recursive and will just forward the request to its parent, etc. >=20 > Adding a lot of debug prints is just not very convenient, so let's add > trace events for the clock requests, one before they are submitted and > one after they are returned. >=20 > That way we can simply toggle the tracing on without modifying the > kernel code and without affecting performances or the kernel logs too > much. >=20 > Reviewed-by: Steven Rostedt (Google) > Signed-off-by: Maxime Ripard > --- Applied to clk-next