* drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:928 gmc_v6_0_hw_init() warn: missing error code? 'r'
@ 2022-12-08 6:25 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2022-12-08 6:25 UTC (permalink / raw)
To: oe-kbuild, Xiaojian Du
Cc: lkp, oe-kbuild-all, linux-kernel, Alex Deucher, Huang Rui
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8ed710da2873c2aeb3bb805864a699affaf1d03b
commit: 479e3b02b73a2de2b19df2950863149c59d57bfe drm/amdgpu: add vram check function for GMC
config: mips-randconfig-m031-20221207
compiler: mips-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:928 gmc_v6_0_hw_init() warn: missing error code? 'r'
vim +/r +928 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
df70502eef80be Ken Wang 2016-01-19 906 static int gmc_v6_0_hw_init(void *handle)
df70502eef80be Ken Wang 2016-01-19 907 {
df70502eef80be Ken Wang 2016-01-19 908 int r;
df70502eef80be Ken Wang 2016-01-19 909 struct amdgpu_device *adev = (struct amdgpu_device *)handle;
df70502eef80be Ken Wang 2016-01-19 910
df70502eef80be Ken Wang 2016-01-19 911 gmc_v6_0_mc_program(adev);
df70502eef80be Ken Wang 2016-01-19 912
df70502eef80be Ken Wang 2016-01-19 913 if (!(adev->flags & AMD_IS_APU)) {
df70502eef80be Ken Wang 2016-01-19 914 r = gmc_v6_0_mc_load_microcode(adev);
df70502eef80be Ken Wang 2016-01-19 915 if (r) {
075719c3cb79f3 Tom St Denis 2016-09-06 916 dev_err(adev->dev, "Failed to load MC firmware!\n");
df70502eef80be Ken Wang 2016-01-19 917 return r;
df70502eef80be Ken Wang 2016-01-19 918 }
df70502eef80be Ken Wang 2016-01-19 919 }
df70502eef80be Ken Wang 2016-01-19 920
df70502eef80be Ken Wang 2016-01-19 921 r = gmc_v6_0_gart_enable(adev);
df70502eef80be Ken Wang 2016-01-19 922 if (r)
df70502eef80be Ken Wang 2016-01-19 923 return r;
df70502eef80be Ken Wang 2016-01-19 924
479e3b02b73a2d Xiaojian Du 2022-01-17 925 if (amdgpu_emu_mode == 1)
479e3b02b73a2d Xiaojian Du 2022-01-17 926 return amdgpu_gmc_vram_checking(adev);
479e3b02b73a2d Xiaojian Du 2022-01-17 927 else
df70502eef80be Ken Wang 2016-01-19 @928 return r;
This seems like a false positive, but it would be more readable as
"return 0;" instead of "return r;"
df70502eef80be Ken Wang 2016-01-19 929 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:928 gmc_v6_0_hw_init() warn: missing error code? 'r'
@ 2022-12-29 13:51 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2022-12-29 13:51 UTC (permalink / raw)
To: oe-kbuild, Xiaojian Du
Cc: lkp, oe-kbuild-all, linux-kernel, Alex Deucher, Huang Rui
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1b929c02afd37871d5afb9d498426f83432e71c2
commit: 479e3b02b73a2de2b19df2950863149c59d57bfe drm/amdgpu: add vram check function for GMC
config: ia64-randconfig-m041-20221229
compiler: ia64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:928 gmc_v6_0_hw_init() warn: missing error code? 'r'
vim +/r +928 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
df70502eef80be Ken Wang 2016-01-19 906 static int gmc_v6_0_hw_init(void *handle)
df70502eef80be Ken Wang 2016-01-19 907 {
df70502eef80be Ken Wang 2016-01-19 908 int r;
df70502eef80be Ken Wang 2016-01-19 909 struct amdgpu_device *adev = (struct amdgpu_device *)handle;
df70502eef80be Ken Wang 2016-01-19 910
df70502eef80be Ken Wang 2016-01-19 911 gmc_v6_0_mc_program(adev);
df70502eef80be Ken Wang 2016-01-19 912
df70502eef80be Ken Wang 2016-01-19 913 if (!(adev->flags & AMD_IS_APU)) {
df70502eef80be Ken Wang 2016-01-19 914 r = gmc_v6_0_mc_load_microcode(adev);
df70502eef80be Ken Wang 2016-01-19 915 if (r) {
075719c3cb79f3 Tom St Denis 2016-09-06 916 dev_err(adev->dev, "Failed to load MC firmware!\n");
df70502eef80be Ken Wang 2016-01-19 917 return r;
df70502eef80be Ken Wang 2016-01-19 918 }
df70502eef80be Ken Wang 2016-01-19 919 }
df70502eef80be Ken Wang 2016-01-19 920
df70502eef80be Ken Wang 2016-01-19 921 r = gmc_v6_0_gart_enable(adev);
df70502eef80be Ken Wang 2016-01-19 922 if (r)
df70502eef80be Ken Wang 2016-01-19 923 return r;
df70502eef80be Ken Wang 2016-01-19 924
479e3b02b73a2d Xiaojian Du 2022-01-17 925 if (amdgpu_emu_mode == 1)
479e3b02b73a2d Xiaojian Du 2022-01-17 926 return amdgpu_gmc_vram_checking(adev);
479e3b02b73a2d Xiaojian Du 2022-01-17 927 else
df70502eef80be Ken Wang 2016-01-19 @928 return r;
"r" is zero. Just return a literal "return 0;" or "return EINVAL;"
df70502eef80be Ken Wang 2016-01-19 929 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-29 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-08 6:25 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:928 gmc_v6_0_hw_init() warn: missing error code? 'r' Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2022-12-29 13:51 Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox