From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Florent DELAHAYE" <kernelorg@undead.fr>,
"Konrad J Hambrick" <kjhambrick@gmail.com>,
"Matt Hansen" <2lprbe78@duck.com>,
"Benoit Grégoire" <benoitg@coeus.ca>,
"Nicholas Johnson" <nicholas.johnson-opensource@outlook.com.au>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Werner Sembach" <wse@tuxedocomputers.com>,
mumblingdrunkard@protonmail.com, linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: [PATCH v2 3/4] x86/PCI: Tidy E820 removal messages
Date: Thu, 8 Dec 2022 13:03:40 -0600 [thread overview]
Message-ID: <20221208190341.1560157-4-helgaas@kernel.org> (raw)
In-Reply-To: <20221208190341.1560157-1-helgaas@kernel.org>
From: Bjorn Helgaas <bhelgaas@google.com>
These messages:
clipped [mem size 0x00000000 64bit] to [mem size 0xfffffffffffa0000 64bit] for e820 entry [mem 0x0009f000-0x000fffff]
aren't as useful as they could be because (a) the resource is often
IORESOURCE_UNSET, so we print the size instead of the start/end and (b) we
print the available resource even if it is empty after removing the E820
entry.
Print the available space by hand to avoid the IORESOURCE_UNSET problem and
only if it's non-empty. No functional change intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Hans de Goede <hdegoede@redhat.com>
---
arch/x86/kernel/resource.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/resource.c b/arch/x86/kernel/resource.c
index bba1abd05bfe..7543a13c8520 100644
--- a/arch/x86/kernel/resource.c
+++ b/arch/x86/kernel/resource.c
@@ -42,8 +42,12 @@ static void remove_e820_regions(struct resource *avail)
resource_clip(avail, e820_start, e820_end);
if (orig.start != avail->start || orig.end != avail->end) {
- pr_info("clipped %pR to %pR for e820 entry [mem %#010Lx-%#010Lx]\n",
- &orig, avail, e820_start, e820_end);
+ pr_info("resource: avoiding allocation from e820 entry [mem %#010Lx-%#010Lx]\n",
+ e820_start, e820_end);
+ if (avail->end > avail->start)
+ pr_info("resource: remaining [mem %#010llx-%#010llx] available\n",
+ (unsigned long long) avail->start,
+ (unsigned long long) avail->end);
orig = *avail;
}
}
--
2.25.1
next prev parent reply other threads:[~2022-12-08 19:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 19:03 [PATCH v2 0/4] PCI: Continue E820 vs host bridge window saga Bjorn Helgaas
2022-12-08 19:03 ` [PATCH v2 1/4] efi/x86: Remove EfiMemoryMappedIO from E820 map Bjorn Helgaas
2022-12-09 8:06 ` Hans de Goede
2022-12-09 11:04 ` Hans de Goede
2022-12-09 20:10 ` Bjorn Helgaas
2023-01-13 10:46 ` Baowen Zheng
2023-01-13 13:54 ` [PATCH " Bjorn Helgaas
2022-12-08 19:03 ` [PATCH v2 2/4] PCI: Skip allocate_resource() if too little space available Bjorn Helgaas
2022-12-08 19:03 ` Bjorn Helgaas [this message]
2022-12-09 18:42 ` [PATCH v2 3/4] x86/PCI: Tidy E820 removal messages Andy Shevchenko
2022-12-09 20:34 ` Bjorn Helgaas
2022-12-09 21:33 ` Andy Shevchenko
2022-12-08 19:03 ` [PATCH v2 4/4] x86/PCI: Fix log message typo Bjorn Helgaas
2022-12-09 18:43 ` Andy Shevchenko
2022-12-09 20:51 ` Bjorn Helgaas
2022-12-09 21:35 ` Andy Shevchenko
2022-12-09 21:52 ` Bjorn Helgaas
2022-12-10 20:55 ` Andy Shevchenko
2022-12-08 20:03 ` [PATCH v2 0/4] PCI: Continue E820 vs host bridge window saga Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208190341.1560157-4-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=2lprbe78@duck.com \
--cc=benoitg@coeus.ca \
--cc=bhelgaas@google.com \
--cc=hdegoede@redhat.com \
--cc=kernelorg@undead.fr \
--cc=kjhambrick@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mumblingdrunkard@protonmail.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox