Re: [Patch net-next v3 00/13] net: dsa: microchip: add PTP support for KSZ9563/KSZ8563 and LAN937x

Vladimir Oltean
2022-12-09T15:24:41Z

On Fri, Dec 09, 2022 at 12:54:24PM +0530, Arun Ramadoss wrote:
> KSZ9563/KSZ8563 and LAN937x switch are capable for supporting IEEE 1588 PTP
> protocol. LAN937x has the same PTP register set similar to KSZ9563, hence the
> implementation has been made common for the KSZ switches. KSZ9563 does not
> support two step timestamping but LAN937x supports both. Tested the 1step &
> 2step p2p timestamping in LAN937x and p2p1step timestamping in KSZ9563.
>
> This patch series is based on the Christian Eggers PTP support for KSZ9563.
> Applied the Christian patch and updated as per the latest refactoring of KSZ
> series code. The features added on top are PTP packet Interrupt
> implementation based on nested handler, LAN937x two step timestamping and
> programmable per_out pins.

From my perspective, the DSA API is used correctly and it should be good
to go in the next patchset iteration. API usage is about all I tried to
concentrate upon. I of course encourage Richard and Christian to point out
if there's something out of the ordinary on the protocol side of things.