Re: [PATCH v2 3/4] x86/PCI: Tidy E820 removal messages

Andy Shevchenko
2022-12-09T18:42:36Z

On Thu, Dec 08, 2022 at 01:03:40PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> These messages:
>
> clipped [mem size 0x00000000 64bit] to [mem size 0xfffffffffffa0000 64bit] for e820 entry [mem 0x0009f000-0x000fffff]
>
> aren't as useful as they could be because (a) the resource is often
> IORESOURCE_UNSET, so we print the size instead of the start/end and (b) we
> print the available resource even if it is empty after removing the E820
> entry.
>
> Print the available space by hand to avoid the IORESOURCE_UNSET problem and
> only if it's non-empty. No functional change intended.

...

> + if (avail->end > avail->start)
> + pr_info("resource: remaining [mem %#010llx-%#010llx] available\n",
> + (unsigned long long) avail->start,
> + (unsigned long long) avail->end);

Is there any point why we do not use %pa for resource_size_t parameters?

--
With Best Regards,
Andy Shevchenko