From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D3A0C4332F for ; Sat, 10 Dec 2022 09:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbiLJJp1 (ORCPT ); Sat, 10 Dec 2022 04:45:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbiLJJpV (ORCPT ); Sat, 10 Dec 2022 04:45:21 -0500 Received: from 1wt.eu (wtarreau.pck.nerim.net [62.212.114.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 959AB16588 for ; Sat, 10 Dec 2022 01:45:11 -0800 (PST) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 2BA9iqnK021841; Sat, 10 Dec 2022 10:44:52 +0100 Date: Sat, 10 Dec 2022 10:44:52 +0100 From: Willy Tarreau To: Sven Schnelle Cc: "Paul E . McKenney" , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] nolibc: add support for s390 Message-ID: <20221210094452.GF21743@1wt.eu> References: <20221209141939.3634586-1-svens@linux.ibm.com> <20221209141939.3634586-3-svens@linux.ibm.com> <20221210090728.GB21743@1wt.eu> <20221210093734.GE21743@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 10, 2022 at 10:39:43AM +0100, Sven Schnelle wrote: > Willy Tarreau writes: > > > On Sat, Dec 10, 2022 at 10:34:08AM +0100, Sven Schnelle wrote: > >> So it should be: > >> > >> >> +#elif defined(__s390x__) > >> >> +#include "arch-s390.h" > >> > >> I'm fine with both - either you fixing it up or me sending a v2. > > > > As you like. If you prefer to rename the file to s390x as your colleague > > suggested, I'll then ask you to send a v2. Otherwise either Paul or I can > > drop that 'x' in the #include. > > Just drop the 'x'. Thanks! :) OK will do, thank you! Wlily