The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@rivosinc.com>
To: Arnd Bergmann <arnd@arndb.de>,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 00/24] Remove COMMAND_LINE_SIZE from uapi
Date: Sat, 10 Dec 2022 22:13:34 -0800	[thread overview]
Message-ID: <20221211061358.28035-1-palmer@rivosinc.com> (raw)

This all came up in the context of increasing COMMAND_LINE_SIZE in the
RISC-V port.  In theory that's a UABI break, as COMMAND_LINE_SIZE is the
maximum length of /proc/cmdline and userspace could staticly rely on
that to be correct.

Usually I wouldn't mess around with changing this sort of thing, but
PowerPC increased it with a5980d064fe2 ("powerpc: Bump COMMAND_LINE_SIZE
to 2048").  There are also a handful of examples of COMMAND_LINE_SIZE
increasing, but they're from before the UAPI split so I'm not quite sure
what that means: e5a6a1c90948 ("powerpc: derive COMMAND_LINE_SIZE from
asm-generic"), 684d2fd48e71 ("[S390] kernel: Append scpdata to kernel
boot command line"), 22242681cff5 ("MIPS: Extend COMMAND_LINE_SIZE"),
and 2b74b85693c7 ("sh: Derive COMMAND_LINE_SIZE from
asm-generic/setup.h.").

It seems to me like COMMAND_LINE_SIZE really just shouldn't have been
part of the uapi to begin with, and userspace should be able to handle
/proc/cmdline of whatever length it turns out to be.  I don't see any
references to COMMAND_LINE_SIZE anywhere but Linux via a quick Google
search, but that's not really enough to consider it unused on my end.

The feedback on the v1 seemed to indicate that COMMAND_LINE_SIZE really
shouldn't be part of uapi, so this now touches all the ports.  I've
tried to split this all out and leave it bisectable, but I haven't
tested it all that aggressively.

Changes since v1 <https://lore.kernel.org/all/20210423025545.313965-1-palmer@dabbelt.com/>:
* Touches every arch.



             reply	other threads:[~2022-12-11  6:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11  6:13 Palmer Dabbelt [this message]
2022-12-11  6:13 ` [PATCH v2 01/24] alpha: Remove COMMAND_LINE_SIZE from uapi Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 02/24] arm: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 03/24] arm64: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 04/24] ia64: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 05/24] m68k: " Palmer Dabbelt
2023-01-16 10:07   ` Geert Uytterhoeven
2022-12-11  6:13 ` [PATCH v2 06/24] microblaze: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 07/24] mips: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 08/24] parisc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 09/24] powerpc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 10/24] sparc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 11/24] xtensa: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 12/24] asm-generic: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 13/24] alpha: Remove empty <uapi/asm/setup.h> Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 14/24] arc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 15/24] arm64: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 16/24] m68k: " Palmer Dabbelt
2023-01-16 10:07   ` Geert Uytterhoeven
2022-12-11  6:13 ` [PATCH v2 17/24] microblaze: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 18/24] mips: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 19/24] parisc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 20/24] powerpc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 21/24] s390: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 22/24] sparc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 23/24] x86: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 24/24] xtensa: " Palmer Dabbelt
2023-02-10 17:10 ` [PATCH v2 00/24] Remove COMMAND_LINE_SIZE from uapi Alexandre Ghiti
2023-02-10 19:37   ` Arnd Bergmann
2023-02-13  7:40     ` Alexandre Ghiti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221211061358.28035-1-palmer@rivosinc.com \
    --to=palmer@rivosinc.com \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox