From: Christoph Hellwig <hch@lst.de>
To: Klaus Jensen <its@irrelevant.dk>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-kernel@vger.kernel.org, Klaus Jensen <k.jensen@samsung.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] nvme-pci: fix doorbell buffer value endianness
Date: Tue, 13 Dec 2022 09:50:57 +0100 [thread overview]
Message-ID: <20221213085057.GA3998@lst.de> (raw)
In-Reply-To: <20221212150243.41283-1-its@irrelevant.dk>
On Mon, Dec 12, 2022 at 04:02:43PM +0100, Klaus Jensen wrote:
> - old_value = *dbbuf_db;
> - *dbbuf_db = value;
> + old_value = le32_to_cpu(*dbbuf_db);
> + *dbbuf_db = cpu_to_le32(value);
As the buildbot noticed, this now means dbbuf_dbs needs to be
a __le32, and the endianess annoations will have to wee through
quite a few places.
next prev parent reply other threads:[~2022-12-13 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 15:02 [PATCH] nvme-pci: fix doorbell buffer value endianness Klaus Jensen
2022-12-12 21:55 ` kernel test robot
2022-12-13 8:50 ` Christoph Hellwig [this message]
2022-12-13 8:52 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213085057.GA3998@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox