From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE89CC10F1B for ; Tue, 13 Dec 2022 19:26:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236525AbiLMT0k (ORCPT ); Tue, 13 Dec 2022 14:26:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236155AbiLMT0h (ORCPT ); Tue, 13 Dec 2022 14:26:37 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B12A22531 for ; Tue, 13 Dec 2022 11:26:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B26E61598 for ; Tue, 13 Dec 2022 19:26:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B7ADC433D2; Tue, 13 Dec 2022 19:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670959596; bh=QK2oIpKFkW8Y+pz74LHORvAxoSG1SnUXy4S3zV/L44U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uT2x8oDPFQmOBhB06fHpXNUG8BIaSfysV1d0mSqOFUvwRfazhlQuGTCRhl/ICwcX3 atRzYdVQCI2MxWZGJ1fhvuz2tWgKyT8mgq9/hsMktCizQBril30G86ftXB/uZb8pF0 76nhXKgy3S1DoVKbelp+0TX6l9LPsW7tJwAtk6Iek7gBQ0SjSbZ3UBHB0gJpL47izZ pdTzrj9cns4eE1fHszq2m+KhynY2QYJ9/omZdazrJSvek/492QSB63e7XoGfVNWc+L ShQIINlai/aocSwdyFEL+yE/VsHVs9UD8/HtoIVHIlpH+HyTxC/Mi4ZPqmU0uKksKa i0z/sQc+VdkaA== From: SeongJae Park To: Kefeng Wang Cc: Andrew Morton , David Hildenbrand , Oscar Salvador , SeongJae Park , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev, vishal.moola@gmail.com, willy@infradead.org Subject: Re: [PATCH -next 8/8] mm: damon: remove unneed damon_get_page() Date: Tue, 13 Dec 2022 19:26:33 +0000 Message-Id: <20221213192633.138774-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221213092735.187924-9-wangkefeng.wang@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kefeng, On Tue, 13 Dec 2022 17:27:35 +0800 Kefeng Wang wrote: > After all damon_get_page() callers are converted to damon_get_folio(), > remove unneed wrapper damon_get_page(). > > Signed-off-by: Kefeng Wang > --- > mm/damon/ops-common.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h > index 4ee607813981..35a2e42a27da 100644 > --- a/mm/damon/ops-common.h > +++ b/mm/damon/ops-common.h > @@ -8,13 +8,6 @@ > #include > > struct folio *damon_get_folio(unsigned long pfn); > -static inline struct page *damon_get_page(unsigned long pfn) > -{ > - struct folio *folio = damon_get_folio(pfn); > - > - return &folio->page; > -} > - > void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr); Let's keep the one blank line before damon_ptep_mkold(). > void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr); > > -- > 2.35.3 Thanks, SJ