public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	agross@kernel.org, andersson@kernel.org,
	krzysztof.kozlowski@linaro.org, linux-arm-msm@vger.kernel.org
Cc: marijn.suijten@somainline.org,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: dispcc-sm6115: Shrink single-parent definitions
Date: Tue, 13 Dec 2022 14:24:19 -0800	[thread overview]
Message-ID: <20221213222421.7B112C433D2@smtp.kernel.org> (raw)
In-Reply-To: <20221213104333.27548-1-konrad.dybcio@linaro.org>

Quoting Konrad Dybcio (2022-12-13 02:43:33)
> @@ -284,12 +268,13 @@ static struct clk_rcg2 disp_cc_mdss_vsync_clk_src = {
>         .cmd_rcgr = 0x20a4,
>         .mnd_width = 0,
>         .hid_width = 5,
> -       .parent_map = disp_cc_parent_map_1,
>         .freq_tbl = ftbl_disp_cc_mdss_esc0_clk_src,
>         .clkr.hw.init = &(struct clk_init_data){
>                 .name = "disp_cc_mdss_vsync_clk_src",
> -               .parent_data = disp_cc_parent_data_1,
> -               .num_parents = ARRAY_SIZE(disp_cc_parent_data_1),
> +               .parent_data = &(const struct clk_parent_data){
> +                       .index = DT_BI_TCXO,
> +               },
> +               .num_parents = 1,
>                 .flags = CLK_SET_RATE_PARENT,
>                 .ops = &clk_rcg2_shared_ops,

Is clk_rcg2_shared_ops and clk_rcg2_ops prepared for a NULL
'parent_map' pointer? _freq_tbl_determine_rate() is never called?

  reply	other threads:[~2022-12-13 22:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 10:43 [PATCH] clk: qcom: dispcc-sm6115: Shrink single-parent definitions Konrad Dybcio
2022-12-13 22:24 ` Stephen Boyd [this message]
2022-12-15 12:58   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221213222421.7B112C433D2@smtp.kernel.org \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox