Re: [PATCH v8 2/7] media: dt-binding: nuvoton: Add bindings for NPCM VCD and ECE engine

Kun-Fa Lin
2022-12-16T06:47:52Z

Hi Krzysztof,

Thanks for the review.

> > Add dt-binding document for Video Capture/Differentiation Engine (VCD)
> > and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs.
>
> Subject: drop second, redundant "bindings for".

OK.

> > +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +
>
> Drop blank line.

OK.

> > + ece: ece@f0820000 {
>
> If this is video codec, then generic node name: "video-codec". "ece" is
> specific, not generic.

OK, will change to "ece: video-codec@f0820000".

> > +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml
> > @@ -0,0 +1,72 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +
>
> Drop blank line.

OK.

> > + memory-region:
> > + description:
> > + CMA pool to use for buffers allocation instead of the default CMA pool.
>
> maxItems: 1

OK.

Regards,
Marvin