From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D943C4167B for ; Wed, 14 Dec 2022 19:07:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238686AbiLNTHC (ORCPT ); Wed, 14 Dec 2022 14:07:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238450AbiLNTG7 (ORCPT ); Wed, 14 Dec 2022 14:06:59 -0500 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CCC5926C3; Wed, 14 Dec 2022 11:06:46 -0800 (PST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 2BEJ1LWU014253; Wed, 14 Dec 2022 13:01:21 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 2BEJ1JSw014250; Wed, 14 Dec 2022 13:01:19 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 14 Dec 2022 13:01:19 -0600 From: Segher Boessenkool To: Christophe Leroy Cc: Ben Hutchings , "gregkh@linuxfoundation.org" , "stable@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Steven Rostedt , Arnaldo Carvalho de Melo , "linux-trace-devel@vger.kernel.org" , Salvatore Bonaccorso Subject: Re: [PATCH] [BACKPORT FOR 4.14] libtraceevent: Fix build with binutils 2.35 Message-ID: <20221214190119.GO25951@gate.crashing.org> References: <20221213202535.GL25951@gate.crashing.org> <8d1c27fe-bac5-8007-a852-f9c15a49a6ba@csgroup.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8d1c27fe-bac5-8007-a852-f9c15a49a6ba@csgroup.eu> User-Agent: Mutt/1.4.2.3i Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2022 at 03:33:24PM +0000, Christophe Leroy wrote: > Le 13/12/2022 à 21:25, Segher Boessenkool a écrit : > > On Tue, Dec 13, 2022 at 07:03:07PM +0100, Christophe Leroy wrote: > >> In binutils 2.35, 'nm -D' changed to show symbol versions along with > >> symbol names, with the usual @@ separator. > > > > 2.37 instead? And --without-symbol-versions is there to restore the > > old behaviour. The script is parsing the output already so this patch > > is simpler maybe, but :-) > > Do you mean that the original commit from Ben should have done it > differently ? Probably. > My patch is only a backport of original commit 39efdd94e314 > ("libtraceevent: Fix build with binutils 2.35") due to Makefile being at > a different place in 4.14. . It's not such a great idea to spread misinformation further, imo. Maybe the mailing list archives will help dampen that already now. Thanks, Segher