From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A3FA3C4167B
	for <linux-kernel@archiver.kernel.org>; Wed, 14 Dec 2022 21:43:38 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229758AbiLNVnh (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 14 Dec 2022 16:43:37 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38358 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229737AbiLNVn0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Dec 2022 16:43:26 -0500
Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [IPv6:2a01:37:1000::53df:5f64:0])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1846C31DE8;
        Wed, 14 Dec 2022 13:43:24 -0800 (PST)
Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
         client-signature RSA-PSS (4096 bits) client-digest SHA256)
        (Client CN "*.hostsharing.net", Issuer "RapidSSL Global TLS RSA4096 SHA256 2022 CA1" (verified OK))
        by bmailout1.hostsharing.net (Postfix) with ESMTPS id 18C2E300097BD;
        Wed, 14 Dec 2022 22:43:21 +0100 (CET)
Received: by h08.hostsharing.net (Postfix, from userid 100393)
        id 0C12910A68; Wed, 14 Dec 2022 22:43:21 +0100 (CET)
Date:   Wed, 14 Dec 2022 22:43:21 +0100
From:   Lukas Wunner <lukas@wunner.de>
To:     Florian Weimer <fweimer@redhat.com>,
        James Bottomley <James.Bottomley@HansenPartnership.com>
Cc:     linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efitools: Include <strings.h> for the strcasecmp function
Message-ID: <20221214214321.GA23425@wunner.de>
References: <87pmcllll9.fsf@oldenburg.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pmcllll9.fsf@oldenburg.str.redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[+cc James]

On Wed, Dec 14, 2022 at 10:30:26PM +0100, Florian Weimer wrote:
> Otherwise, an implicit function declaration is the result, and the
> code may fail to compile with future compilers.
> 
> ---
>  efi-updatevar.c | 1 +
>  1 file changed, 1 insertion(+)

efitools appears to be maintained by James, so you may want to cc
your submissions to him.

Your patches are missing a DCO, yet existing commits in the efitools
repository have one.  You may want to respin with your Signed-off-by
added.

Thanks,

Lukas

> 
> diff --git a/efi-updatevar.c b/efi-updatevar.c
> index 4247105..033d938 100644
> --- a/efi-updatevar.c
> +++ b/efi-updatevar.c
> @@ -11,6 +11,7 @@
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
> +#include <strings.h>
>  #include <sys/stat.h>
>  #include <fcntl.h>
>  #include <unistd.h>
> 
> Related to:
> 
>   <https://fedoraproject.org/wiki/Changes/PortingToModernC>
>   <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>
>