From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Christoph Hellwig <hch@lst.de>,
Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, m.szyprowski@samsung.com,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
iommu@lists.linux.dev
Subject: Re: [6.2][regression] after commit ffcb754584603adf7039d7972564fbf6febdc542 all sound devices disappeared (due BUG at mm/page_alloc.c:3592!)
Date: Fri, 16 Dec 2022 13:15:19 +0100 [thread overview]
Message-ID: <20221216121519.GA5710@lst.de> (raw)
In-Reply-To: <a76cb262-a24f-e113-5680-2025aa143ee6@arm.com>
On Fri, Dec 16, 2022 at 11:40:57AM +0000, Robin Murphy wrote:
> On 2022-12-16 06:46, Christoph Hellwig wrote:
>> Ok, it seems like the sound noncontig alloc code that I already
>> commented on as potentially bogus GFP_GOMP mapping trips this. I think
>> for now the right thing would be to revert the hunk in dma-iommu.c
>> (see patch below). The other thing to try would be to remove both
>> uses GFP_COMP in sound/core/memalloc.c, which should have the same
>> effect.
>
> Or we explicitly strip the flag in dma_alloc_noncontiguous() (and maybe
> dma_alloc_pages() as well) for consistency with dma_alloc_attrs(). That
> seems like it might be the most robust option.
In the long run warning there and returning an error seems like the
right thing to do, yes. I'm just a little worried doing this right now
after the merge window.
next prev parent reply other threads:[~2022-12-16 12:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 14:17 [6.2][regression] after commit ffcb754584603adf7039d7972564fbf6febdc542 all sound devices disappeared (due BUG at mm/page_alloc.c:3592!) Mikhail Gavrilov
2022-12-15 18:23 ` Kai Vehmanen
2022-12-16 0:06 ` Joan Bruguera
2022-12-16 6:46 ` Christoph Hellwig
2022-12-16 11:40 ` Robin Murphy
2022-12-16 12:15 ` Christoph Hellwig [this message]
2022-12-16 12:52 ` Robin Murphy
2022-12-22 12:17 ` [6.2][regression] after commit ffcb754584603adf7039d7972564fbf6febdc542 all sound devices disappeared (due BUG at mm/page_alloc.c:3592!) #forregzbot Thorsten Leemhuis
2022-12-24 7:20 ` Thorsten Leemhuis
[not found] <CABXGCsPnpu0TGHnvXM1we7q1t3tJAOYW2rA=>
2022-12-15 23:52 ` [6.2][regression] after commit ffcb754584603adf7039d7972564fbf6febdc542 all sound devices disappeared (due BUG at mm/page_alloc.c:3592!) Joan Bruguera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221216121519.GA5710@lst.de \
--to=hch@lst.de \
--cc=alsa-devel@alsa-project.org \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=robin.murphy@arm.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox