From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1552DC4167B for ; Fri, 16 Dec 2022 20:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231838AbiLPUfR (ORCPT ); Fri, 16 Dec 2022 15:35:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230171AbiLPUfN (ORCPT ); Fri, 16 Dec 2022 15:35:13 -0500 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 907563B9FC for ; Fri, 16 Dec 2022 12:35:12 -0800 (PST) Received: by mail-pl1-x629.google.com with SMTP id 4so3448317plj.3 for ; Fri, 16 Dec 2022 12:35:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r/hPsvfVFhvh9haGKLunftTxDivO3JDSv2xgcZcDsPA=; b=HvYgLvzKyB+qontqJaRxw4JCx5keeHG+fJkK4euqza/veNJBrv8ioB2lE6IXO0VI3n esNkVZN37PeYArveZqKULuIZn7F1HgLhZ7ZOg+3+Q1JX2YF8qc0w9Jp9AkLmPCAxaHXq 9NQKhQSoi5qpbGUeWi2a7tg62N+alAyY5VjrQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r/hPsvfVFhvh9haGKLunftTxDivO3JDSv2xgcZcDsPA=; b=cwmhJedbv/y15uNs72iNDLTPqg8ppERRVM6SDZr5wYDCBiEMEha+M1P4O7hKnLjVWJ R5YY+C3rX7dkZd02XQT4X3AQ56U7ouWfDyfGhGudnRKlH7svKnk663qO8gtNLsi/Hd52 Q7/ZW2Gz0CTDYyWQqQUQIErOntFu/Bwjb5tcOdjCtXDrgMm5RkDca08+wNvkwrWB7bBq Sw/rJOQvnEH3sGEgLv0OR01NHfub2ysDsjHcCm09p+v22jmJeD2TZopamG90Eu+SPy16 kgCcBXvspf01LC6n+bplei144L8vWQeUWOvfjQZmsIVSg5he2sWqNZR4NkjhV0Wz7D9x bdvQ== X-Gm-Message-State: AFqh2kqbr2pFui7Hd/qe/hEZwlahuGJevtlK/WwKaZfatfybgDiPgg5p cPKdFTF9f4XbbID5ICN58BQIaw== X-Google-Smtp-Source: AMrXdXt8w3fEbmDbvTVO1Z+Z3U9o6ttyQJonRnCieP1HRMjM8XxbOprdtKK2Ib64+zi1S8WdDE+mjA== X-Received: by 2002:a17:902:d4c6:b0:191:a19:e768 with SMTP id o6-20020a170902d4c600b001910a19e768mr1842628plg.48.1671222912139; Fri, 16 Dec 2022 12:35:12 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i4-20020a17090332c400b0018913417ba2sm2039045plr.130.2022.12.16.12.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 12:35:11 -0800 (PST) Date: Fri, 16 Dec 2022 12:35:10 -0800 From: Kees Cook To: Jeff Xu Cc: Andrew Morton , Peter Xu , jeffxu@chromium.org, skhan@linuxfoundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org, kernel test robot Subject: Re: [PATCH v6 3/6] mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC Message-ID: <202212161233.85C9783FB@keescook> References: <20221207154939.2532830-1-jeffxu@google.com> <20221207154939.2532830-4-jeffxu@google.com> <202212080821.5AE7EE99@keescook> <20221216094259.bec91e4abd6cf54a05ce2813@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2022 at 10:11:44AM -0800, Jeff Xu wrote: > Once per boot seems too little, it would be nice if we can list all processes. > I agree ratelimited might be too much. > There is a feature gap here for logging. > > Kees, what do you think ? I agree once per boot is kind of frustrating "I fixed the one warning, oh, now it's coming from a different process". But ratelimit is, in retrospect, still too often. Let's go with per boot -- this should be noisy "enough" to get the changes in API into the callers without being too much of a hassle. -- Kees Cook