From: Stephen Boyd <sboyd@kernel.org>
To: Akhil P Oommen <quic_akhilpo@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
dri-devel@lists.freedesktop.org,
freedreno <freedreno@lists.freedesktop.org>,
linux-arm-msm@vger.kernel.org
Cc: Akhil P Oommen <quic_akhilpo@quicinc.com>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag
Date: Fri, 16 Dec 2022 08:09:29 -0800 [thread overview]
Message-ID: <20221216160931.E1AF5C433EF@smtp.kernel.org> (raw)
In-Reply-To: <20221215203751.2.Ic128c1df50b7fc9a6b919932a3b41a799b5ed5e8@changeid>
Quoting Akhil P Oommen (2022-12-15 07:10:58)
> Add support for the newly added 'synced_poweroff' genpd flag. This allows
> some clients (like adreno gpu driver) to request gdsc driver to ensure
> a votable gdsc (like gpucc cx gdsc) has collapsed at hardware.
>
> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
> ---
>
> drivers/clk/qcom/gdsc.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c
> index 9e4d6ce891aa..575019ba4768 100644
> --- a/drivers/clk/qcom/gdsc.c
> +++ b/drivers/clk/qcom/gdsc.c
> @@ -136,7 +136,8 @@ static int gdsc_update_collapse_bit(struct gdsc *sc, bool val)
> return 0;
> }
>
> -static int gdsc_toggle_logic(struct gdsc *sc, enum gdsc_status status)
> +static int gdsc_toggle_logic(struct gdsc *sc, enum gdsc_status status,
> + bool force_sync)
Maybe just 'wait'? That matches kernel style and is short.
next prev parent reply other threads:[~2022-12-16 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 15:10 [PATCH 0/5] Improve GPU reset sequence for Adreno GPU Akhil P Oommen
2022-12-15 15:10 ` [PATCH 1/5] PM: domains: Allow a genpd consumer to require a synced power off Akhil P Oommen
2022-12-15 15:10 ` [PATCH 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag Akhil P Oommen
2022-12-16 16:09 ` Stephen Boyd [this message]
2022-12-15 15:10 ` [PATCH 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver Akhil P Oommen
2022-12-15 15:11 ` [PATCH 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset' Akhil P Oommen
2022-12-15 15:11 ` [PATCH 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse Akhil P Oommen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221216160931.E1AF5C433EF@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox