From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52EC8C4332F for ; Sun, 18 Dec 2022 16:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233167AbiLRQ7u (ORCPT ); Sun, 18 Dec 2022 11:59:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231251AbiLRQ5s (ORCPT ); Sun, 18 Dec 2022 11:57:48 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4AC21CB22; Sun, 18 Dec 2022 08:20:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1A4AAB80BA4; Sun, 18 Dec 2022 16:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA0ADC433D2; Sun, 18 Dec 2022 16:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671380414; bh=YRB7LULLjg1RZAf4ZJkr7VcQB7304qoXiHfCRF+n0jY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sQoHRWgxM2nf8VH0IIeM1xBNv965E6RR4xNcB/AMcFcNDlboYM8WCfN+2DdMgp6Mq fvpsDjOwA9m1tNYDfg92RKhJjeRLFHTmGTRZh/LX/dRCrYRVzYNK2wj+bnI3EqGCBj dzimnBXTTt3XEfk4jpqr864mRv7OjecK8uGVVryxn63QJqbyMpA5ybrKfK1pdTXzMq 7EPvDYd2w9CwCj5Jij6k1PPjAbci5+zxRLluckkY+m2JW2av5U1Q0vV85a7tV3s3AE BZ4kp9n1b5iTWnfqJ/YPvad/0uG8woYGGIt9KvlC28RqTw494qfOno5AQm4uqSB+gB POYcwZeCL6KMg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xiu Jianfeng , Patrice Chotard , Stephen Boyd , Sasha Levin , mturquette@baylibre.com, avolmat@me.com, windhl@126.com, linux-clk@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 30/30] clk: st: Fix memory leak in st_of_quadfs_setup() Date: Sun, 18 Dec 2022 11:18:35 -0500 Message-Id: <20221218161836.933697-30-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221218161836.933697-1-sashal@kernel.org> References: <20221218161836.933697-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiu Jianfeng [ Upstream commit cfd3ffb36f0d566846163118651d868e607300ba ] If st_clk_register_quadfs_pll() fails, @lock should be freed before goto @err_exit, otherwise will cause meory leak issue, fix it. Signed-off-by: Xiu Jianfeng Link: https://lore.kernel.org/r/20221122133614.184910-1-xiujianfeng@huawei.com Reviewed-by: Patrice Chotard Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/st/clkgen-fsyn.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c index a156bd0c6af7..9eff05386ef9 100644 --- a/drivers/clk/st/clkgen-fsyn.c +++ b/drivers/clk/st/clkgen-fsyn.c @@ -943,9 +943,10 @@ static void __init st_of_quadfs_setup(struct device_node *np, clk = st_clk_register_quadfs_pll(pll_name, clk_parent_name, data, reg, lock); - if (IS_ERR(clk)) + if (IS_ERR(clk)) { + kfree(lock); goto err_exit; - else + } else pr_debug("%s: parent %s rate %u\n", __clk_get_name(clk), __clk_get_name(clk_get_parent(clk)), -- 2.35.1