From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F187C4332F for ; Mon, 19 Dec 2022 10:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231448AbiLSKHo (ORCPT ); Mon, 19 Dec 2022 05:07:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbiLSKHm (ORCPT ); Mon, 19 Dec 2022 05:07:42 -0500 Received: from outbound-smtp28.blacknight.com (outbound-smtp28.blacknight.com [81.17.249.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37C8C26FC for ; Mon, 19 Dec 2022 02:07:41 -0800 (PST) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp28.blacknight.com (Postfix) with ESMTPS id 16A23CCD39 for ; Mon, 19 Dec 2022 10:07:39 +0000 (GMT) Received: (qmail 2594 invoked from network); 19 Dec 2022 10:07:38 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 19 Dec 2022 10:07:38 -0000 Date: Mon, 19 Dec 2022 10:07:34 +0000 From: Mel Gorman To: Lorenzo Stoakes Cc: Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrey Konovalov , Ingo Molnar , Marco Elver , Michal Hocko Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list() Message-ID: <20221219100734.jag6zejp4tug77yq@techsingularity.net> References: <20221217001554.554913-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote: > + Mel > > On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote: > > I think we're waiting to see if any users show up. It's only been 18 > > months or so, so perhaps wait a little longer? > > Apologies, I should have researched the background of this further. I see it was > added speculatively in 0f87d9d30f. > > > Also, if we do get rid of this, then __alloc_pages_bulk() can lose > > the "list" argument. > > Ack. Will do a v2 if Mel feels it's appropriate to remove at this stage, > otherwise we can drop the idea and wait for users to emerge. I reckon we should give it another few months until May. There has been one user recently that tried to use list but it turned out arrays were more appropriate. -- Mel Gorman SUSE Labs