Re: [PATCH 4/7] spi: cadence: Change dt-bindings documentation for Cadence XSPI controller

Krzysztof Kozlowski
2022-12-20T14:09:35Z

On 19/12/2022 15:42, Witold Sadowski wrote:
> Add parameter cdns,read-size.
> Parameter is controlling SDMA read size length.

Use subject prefixes matching the subsystem (git log --oneline -- ...).

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

>
> Signed-off-by: Witold Sadowski <wsadowski@marvell.com>
> ---
> Documentation/devicetree/bindings/spi/cdns,xspi.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> index f71a9c74e2ca..1274e3bf68e6 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> @@ -37,6 +37,10 @@ properties:
> interrupts:
> maxItems: 1
>
> + cdns,read-size:
> + items:
> + - description: size of single SDMA read operation

Why is this a property of DT?

> +
> required:
> - compatible
> - reg
> @@ -60,6 +64,7 @@ examples:
> reg-names = "io", "sdma", "aux";
> interrupts = <0 90 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> + cdns,read-size=<0>;

That's not DT coding style.

>
> flash@0 {
> compatible = "jedec,spi-nor";

Best regards,
Krzysztof