From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BFB7C4332F for ; Thu, 22 Dec 2022 12:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235172AbiLVMoW (ORCPT ); Thu, 22 Dec 2022 07:44:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235261AbiLVMoS (ORCPT ); Thu, 22 Dec 2022 07:44:18 -0500 Received: from outbound-smtp15.blacknight.com (outbound-smtp15.blacknight.com [46.22.139.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E77423E9F for ; Thu, 22 Dec 2022 04:44:16 -0800 (PST) Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp15.blacknight.com (Postfix) with ESMTPS id BD89C1C36CD for ; Thu, 22 Dec 2022 12:44:14 +0000 (GMT) Received: (qmail 19094 invoked from network); 22 Dec 2022 12:44:14 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 22 Dec 2022 12:44:14 -0000 Date: Thu, 22 Dec 2022 12:44:12 +0000 From: Mel Gorman To: Yang Shi Cc: Lorenzo Stoakes , Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrey Konovalov , Ingo Molnar , Marco Elver , Michal Hocko Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list() Message-ID: <20221222124412.rpnl2vojnx7izoow@techsingularity.net> References: <20221217001554.554913-1-lstoakes@gmail.com> <20221219100734.jag6zejp4tug77yq@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 20, 2022 at 09:56:19AM -0800, Yang Shi wrote: > On Mon, Dec 19, 2022 at 2:07 AM Mel Gorman wrote: > > > > On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote: > > > + Mel > > > > > > On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote: > > > > I think we're waiting to see if any users show up. It's only been 18 > > > > months or so, so perhaps wait a little longer? > > > > > > Apologies, I should have researched the background of this further. I see it was > > > added speculatively in 0f87d9d30f. > > > > > > > Also, if we do get rid of this, then __alloc_pages_bulk() can lose > > > > the "list" argument. > > > > > > Ack. Will do a v2 if Mel feels it's appropriate to remove at this stage, > > > otherwise we can drop the idea and wait for users to emerge. > > > > I reckon we should give it another few months until May. There has been > > one user recently that tried to use list but it turned out arrays were > > more appropriate. > > Another recent try was the patches for dm-crypt. However Mel suggested > adding a callback interface instead of using list since list is not > necessary for that usecase. Or are we talking about the same one? > That was the one I was thinking of but forgot the specifics so the array comment was wrong. I only remembered that there was an attempted list user but it wasn't the best solution. > I didn't get time to implement Mel's suggestion yet due to my > employment change. Hopefully I can find some time after the new year. > No rush. -- Mel Gorman SUSE Labs