Re: [PATCH 1/5] kbuild: refactor silent mode detection

Nick Desaulniers
2022-12-22T17:51:18Z

On Thu, Dec 22, 2022 at 8:25 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Factor out $(findstring s,...).
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>
> Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 25247f931872..e8ce3e2b30d6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -100,12 +100,12 @@ endif
> # make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS.
>
> ifeq ($(filter 3.%,$(MAKE_VERSION)),)
> -silence:=$(findstring s,$(firstword -$(MAKEFLAGS)))
> +short-opts := $(firstword -$(MAKEFLAGS))
> else
> -silence:=$(findstring s,$(filter-out --%,$(MAKEFLAGS)))
> +short-opts := $(filter-out --%,$(MAKEFLAGS))
> endif
>
> -ifeq ($(silence),s)
> +ifneq ($(findstring s,$(short-opts)),)
> quiet=silent_
> KBUILD_VERBOSE = 0
> endif
> --
> 2.34.1
>

--
Thanks,
~Nick Desaulniers