From: Christoph Hellwig <hch@lst.de>
To: Dan Carpenter <error27@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
oe-kbuild@lists.linux.dev, Sagi Grimberg <sagi@grimberg.me>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: drivers/nvme/host/auth.c:950 nvme_auth_init_ctrl() warn: missing error code? 'ret'
Date: Fri, 23 Dec 2022 17:42:29 +0100 [thread overview]
Message-ID: <20221223164229.GA31884@lst.de> (raw)
In-Reply-To: <Y6XVnWCNx6cB7Itw@kadam>
On Fri, Dec 23, 2022 at 07:21:49PM +0300, Dan Carpenter wrote:
> > - if (!ctrl->opts->dhchap_secret && !ctrl->opts->dhchap_ctrl_secret)
> > + if (!ctrl->host_key && !ctrl->ctrl_key)
> > return ret;
>
> ret is uninitialized now.
Yes. Should be a 'return 0'.
We really need to turn the maybe uninitialized warnings back on.
next prev parent reply other threads:[~2022-12-23 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 11:03 drivers/nvme/host/auth.c:950 nvme_auth_init_ctrl() warn: missing error code? 'ret' Dan Carpenter
2022-12-23 15:47 ` Christoph Hellwig
2022-12-23 16:21 ` Dan Carpenter
2022-12-23 16:42 ` Christoph Hellwig [this message]
2022-12-25 10:36 ` Sagi Grimberg
2022-12-27 17:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221223164229.GA31884@lst.de \
--to=hch@lst.de \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox