From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Alex Gaynor <alex.gaynor@gmail.com>, Andrew Davis <afd@ti.com>,
Kees Cook <keescook@chromium.org>,
Miguel Ojeda <ojeda@kernel.org>,
Wedson Almeida Filho <wedsonaf@google.com>
Subject: [PATCH v2 1/2] .gitinogre: update the command to check tracked files being ignored
Date: Sun, 25 Dec 2022 00:51:37 +0900 [thread overview]
Message-ID: <20221224155138.447912-1-masahiroy@kernel.org> (raw)
Recent git versions do not accept the noted command.
$ git ls-files -i --exclude-standard
fatal: ls-files -i must be used with either -o or -c
The -c was implied for older git versions, but we need to make it
explicit now.
Also, replace --exclude-standard with --exclude-per-directory=.gitignore
so that everyone will get consistent results.
git-ls-files(1) says:
--exclude-standard
Add the standard Git exclusions: .git/info/exclude, .gitignore in
each directory, and the user's global exclusion file.
We never know what are locally added to $GIT_DIR/info/exclude or
$XDG_CONFIG_HOME/git/ignore.
We can only manage .gitignore files committed in the repository.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
(no changes since v1)
.gitignore | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 3ec73ead6757..2e2e3d1eeaee 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,7 +4,7 @@
# subdirectories here. Add them in the ".gitignore" file
# in that subdirectory instead.
#
-# NOTE! Please use 'git ls-files -i --exclude-standard'
+# NOTE! Please use 'git ls-files -i -c --exclude-per-directory=.gitignore'
# command after changing this file, to see if there are
# any tracked files which get ignored after the change.
#
--
2.34.1
next reply other threads:[~2022-12-24 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 15:51 Masahiro Yamada [this message]
2022-12-24 15:51 ` [PATCH v2 2/2] kbuild: make W=1 warn files that are tracked but ignored by git Masahiro Yamada
2022-12-24 18:17 ` kernel test robot
2022-12-27 3:57 ` Nathan Chancellor
2022-12-28 16:48 ` Nicolas Schier
2022-12-29 7:36 ` Masahiro Yamada
2022-12-25 18:37 ` [PATCH v2 1/2] .gitinogre: update the command to check tracked files being ignored Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221224155138.447912-1-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=afd@ti.com \
--cc=alex.gaynor@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox