* [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions
@ 2022-12-26 14:25 Pali Rohár
2023-01-10 9:17 ` OGAWA Hirofumi
0 siblings, 1 reply; 2+ messages in thread
From: Pali Rohár @ 2022-12-26 14:25 UTC (permalink / raw)
To: OGAWA Hirofumi; +Cc: linux-kernel
These functions returns boolean value not wide character.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
fs/fat/namei_vfat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
index 21620054e1c4..0735e4f0aeed 100644
--- a/fs/fat/namei_vfat.c
+++ b/fs/fat/namei_vfat.c
@@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {
/* Characters that are undesirable in an MS-DOS file name */
-static inline wchar_t vfat_bad_char(wchar_t w)
+static inline bool vfat_bad_char(wchar_t w)
{
return (w < 0x0020)
|| (w == '*') || (w == '?') || (w == '<') || (w == '>')
@@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w)
|| (w == '\\');
}
-static inline wchar_t vfat_replace_char(wchar_t w)
+static inline bool vfat_replace_char(wchar_t w)
{
return (w == '[') || (w == ']') || (w == ';') || (w == ',')
|| (w == '+') || (w == '=');
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions
2022-12-26 14:25 [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions Pali Rohár
@ 2023-01-10 9:17 ` OGAWA Hirofumi
0 siblings, 0 replies; 2+ messages in thread
From: OGAWA Hirofumi @ 2023-01-10 9:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: Pali Rohár, linux-kernel
Pali Rohár <pali@kernel.org> writes:
> These functions returns boolean value not wide character.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Thanks.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> fs/fat/namei_vfat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
> index 21620054e1c4..0735e4f0aeed 100644
> --- a/fs/fat/namei_vfat.c
> +++ b/fs/fat/namei_vfat.c
> @@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {
>
> /* Characters that are undesirable in an MS-DOS file name */
>
> -static inline wchar_t vfat_bad_char(wchar_t w)
> +static inline bool vfat_bad_char(wchar_t w)
> {
> return (w < 0x0020)
> || (w == '*') || (w == '?') || (w == '<') || (w == '>')
> @@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w)
> || (w == '\\');
> }
>
> -static inline wchar_t vfat_replace_char(wchar_t w)
> +static inline bool vfat_replace_char(wchar_t w)
> {
> return (w == '[') || (w == ']') || (w == ';') || (w == ',')
> || (w == '+') || (w == '=');
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-10 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-26 14:25 [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions Pali Rohár
2023-01-10 9:17 ` OGAWA Hirofumi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox