From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F385BC5479D for ; Tue, 27 Dec 2022 20:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232842AbiL0Ukj (ORCPT ); Tue, 27 Dec 2022 15:40:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232760AbiL0Uis (ORCPT ); Tue, 27 Dec 2022 15:38:48 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 177BDE0EE; Tue, 27 Dec 2022 12:34:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 76EAE61245; Tue, 27 Dec 2022 20:34:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 243FAC433EF; Tue, 27 Dec 2022 20:34:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672173294; bh=KB6jqn8qsIcdbhOJCjkqiFPAQA6Jfudm4TH68sK+m7g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ToVfKN+wBn0tzlqoU0z1P9s2tNbmimCbuM5lGuKAcKc9gonvjXUyfu62jvTS64wzQ bSowN1CSZqpBa0TG3bBIlgh5rJYPVVu5tqEZHwDnE274lSz/3qTMZN+Rk1zTLgXcq3 6AzX1j/zPBEbL3oSzGm9PwtRwhX/uQJDjRz5Ph1Ed/FkiU0INNAlubM7YEVKif5KLL wx23csvRpERHkk4o7nYIp0N5ukOZOzXlDGtRKNRqcMANO8mUbLg8lUGhsLjVT8yDf6 MvBkfoRXf2C8EZZfYNaiPN3NMI4dcOdF3dLxAYHDpR0c7Qu5cINS6hsl6ld9P8aWuS xHAUDzQ9rcreA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Christophe Leroy , "Naveen N . Rao" , Josh Poimboeuf , Peter Zijlstra , Michael Ellerman , Sasha Levin Subject: [PATCH AUTOSEL 5.15 17/22] objtool: Fix SEGFAULT Date: Tue, 27 Dec 2022 15:34:27 -0500 Message-Id: <20221227203433.1214255-17-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221227203433.1214255-1-sashal@kernel.org> References: <20221227203433.1214255-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe Leroy [ Upstream commit efb11fdb3e1a9f694fa12b70b21e69e55ec59c36 ] find_insn() will return NULL in case of failure. Check insn in order to avoid a kernel Oops for NULL pointer dereference. Tested-by: Naveen N. Rao Reviewed-by: Naveen N. Rao Acked-by: Josh Poimboeuf Acked-by: Peter Zijlstra (Intel) Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20221114175754.1131267-9-sv@linux.ibm.com Signed-off-by: Sasha Levin --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 72e5d23f1ad8..e27c73295c41 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -197,7 +197,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, return false; insn = find_insn(file, func->sec, func->offset); - if (!insn->func) + if (!insn || !insn->func) return false; func_for_each_insn(file, func, insn) { -- 2.35.1