* [PATCH] mhi: Update Makefile to used Kconfig flags
@ 2022-12-07 19:26 Carl Vanderlip
2022-12-07 19:58 ` Jeffrey Hugo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Carl Vanderlip @ 2022-12-07 19:26 UTC (permalink / raw)
To: Manivannan Sadhasivam, Hemant Kumar
Cc: Jeffrey Hugo, Carl Vanderlip, mhi, linux-arm-msm, linux-kernel
Makefile was always suggesting to build subdirectories regardless of
Kconfig. Use the Kconfig flags as intended.
Signed-off-by: Carl Vanderlip <quic_carlv@quicinc.com>
---
drivers/bus/mhi/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/mhi/Makefile b/drivers/bus/mhi/Makefile
index 46981331b38f..354204b0ef3a 100644
--- a/drivers/bus/mhi/Makefile
+++ b/drivers/bus/mhi/Makefile
@@ -1,5 +1,5 @@
# Host MHI stack
-obj-y += host/
+obj-$(CONFIG_MHI_BUS) += host/
# Endpoint MHI stack
-obj-y += ep/
+obj-$(CONFIG_MHI_BUS_EP) += ep/
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mhi: Update Makefile to used Kconfig flags
2022-12-07 19:26 [PATCH] mhi: Update Makefile to used Kconfig flags Carl Vanderlip
@ 2022-12-07 19:58 ` Jeffrey Hugo
2022-12-28 16:30 ` Manivannan Sadhasivam
2022-12-28 16:38 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Jeffrey Hugo @ 2022-12-07 19:58 UTC (permalink / raw)
To: Carl Vanderlip, Manivannan Sadhasivam; +Cc: mhi, linux-arm-msm, linux-kernel
On 12/7/2022 12:26 PM, Carl Vanderlip wrote:
> Makefile was always suggesting to build subdirectories regardless of
> Kconfig. Use the Kconfig flags as intended.
>
> Signed-off-by: Carl Vanderlip <quic_carlv@quicinc.com>
Nice catch.
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mhi: Update Makefile to used Kconfig flags
2022-12-07 19:26 [PATCH] mhi: Update Makefile to used Kconfig flags Carl Vanderlip
2022-12-07 19:58 ` Jeffrey Hugo
@ 2022-12-28 16:30 ` Manivannan Sadhasivam
2022-12-28 16:38 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2022-12-28 16:30 UTC (permalink / raw)
To: Carl Vanderlip
Cc: Hemant Kumar, Jeffrey Hugo, mhi, linux-arm-msm, linux-kernel
On Wed, Dec 07, 2022 at 11:26:13AM -0800, Carl Vanderlip wrote:
> Makefile was always suggesting to build subdirectories regardless of
> Kconfig. Use the Kconfig flags as intended.
>
> Signed-off-by: Carl Vanderlip <quic_carlv@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> drivers/bus/mhi/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/Makefile b/drivers/bus/mhi/Makefile
> index 46981331b38f..354204b0ef3a 100644
> --- a/drivers/bus/mhi/Makefile
> +++ b/drivers/bus/mhi/Makefile
> @@ -1,5 +1,5 @@
> # Host MHI stack
> -obj-y += host/
> +obj-$(CONFIG_MHI_BUS) += host/
>
> # Endpoint MHI stack
> -obj-y += ep/
> +obj-$(CONFIG_MHI_BUS_EP) += ep/
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mhi: Update Makefile to used Kconfig flags
2022-12-07 19:26 [PATCH] mhi: Update Makefile to used Kconfig flags Carl Vanderlip
2022-12-07 19:58 ` Jeffrey Hugo
2022-12-28 16:30 ` Manivannan Sadhasivam
@ 2022-12-28 16:38 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2022-12-28 16:38 UTC (permalink / raw)
To: Carl Vanderlip
Cc: Hemant Kumar, Jeffrey Hugo, mhi, linux-arm-msm, linux-kernel
On Wed, Dec 07, 2022 at 11:26:13AM -0800, Carl Vanderlip wrote:
> Makefile was always suggesting to build subdirectories regardless of
> Kconfig. Use the Kconfig flags as intended.
>
> Signed-off-by: Carl Vanderlip <quic_carlv@quicinc.com>
Applied to mhi-next!
Thanks,
Mani
> ---
> drivers/bus/mhi/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/Makefile b/drivers/bus/mhi/Makefile
> index 46981331b38f..354204b0ef3a 100644
> --- a/drivers/bus/mhi/Makefile
> +++ b/drivers/bus/mhi/Makefile
> @@ -1,5 +1,5 @@
> # Host MHI stack
> -obj-y += host/
> +obj-$(CONFIG_MHI_BUS) += host/
>
> # Endpoint MHI stack
> -obj-y += ep/
> +obj-$(CONFIG_MHI_BUS_EP) += ep/
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-28 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-07 19:26 [PATCH] mhi: Update Makefile to used Kconfig flags Carl Vanderlip
2022-12-07 19:58 ` Jeffrey Hugo
2022-12-28 16:30 ` Manivannan Sadhasivam
2022-12-28 16:38 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox