From: Bjorn Helgaas <helgaas@kernel.org>
To: "Lee, Ron" <ron.lee@intel.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"lmajczak@google.com" <lmajczak@google.com>,
"Jain, Rajat" <rajatja@google.com>,
Ron Lee <ron.lee.intel@gmail.com>
Subject: Re: [PATCH v2] PCI: Fix up L1SS capability for Intel Apollolake PCIe bridge
Date: Thu, 29 Dec 2022 13:07:25 -0600 [thread overview]
Message-ID: <20221229190725.GA620646@bhelgaas> (raw)
In-Reply-To: <BL0PR11MB3457C04B0BF3E0F06A8607F2FEEA9@BL0PR11MB3457.namprd11.prod.outlook.com>
On Tue, Dec 20, 2022 at 09:11:31AM +0000, Lee, Ron wrote:
> > On Fri, Dec 16, 2022 at 04:29:39PM +0000, Lee, Ron wrote:
> > > > On Thu, Dec 15, 2022 at 05:13:57PM +0800, Ron Lee wrote:
> > Even if you haven't seen a battery life issue, I suspect you might be
> > able to measure a power consumption difference if you looked for it
> > and likely could see issues with manual ASPM enable/disable using
> > sysfs. That might be a legitimate reason for this quirk, and if
> > it is, we should mention it here.
>
> We can arrange the power measurement, but I doubt this quirk has
> correlation to power consumption. My point is that the ASPM
> behavior is not changed with or without this quirk.
Makes sense.
> ...
> I agree that, I ever try to recover the link by traversing list, but
> it didn't work and the capability list have no method to do reverse
> traversal. One approach may save the whole capability list before
> suspend, and check each capability link then restore the missing one
> after resume. Do you think it's practical ? It is appreciated if
> you could recommend a practical solution for this issue.
The issue being "lspci doesn't show L1SS after suspend/resume"?
Is the point of this basically to fix lspci output after
suspend/resume? Or is there something else this fixes?
It sounds like ASPM and L1SS works correctly after suspend/resume
even without this patch?
Bjorn
next prev parent reply other threads:[~2022-12-29 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 9:13 [PATCH v2] PCI: Fix up L1SS capability for Intel Apollolake PCIe bridge Ron Lee
2022-12-15 15:16 ` Bjorn Helgaas
2022-12-16 16:29 ` Lee, Ron
2022-12-16 17:48 ` Bjorn Helgaas
2022-12-20 9:11 ` Lee, Ron
2022-12-29 19:07 ` Bjorn Helgaas [this message]
2022-12-30 12:13 ` Lee, Ron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229190725.GA620646@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lmajczak@google.com \
--cc=rajatja@google.com \
--cc=ron.lee.intel@gmail.com \
--cc=ron.lee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox