* [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo
2022-12-17 18:08 [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt Adam Ford
@ 2022-12-17 18:08 ` Adam Ford
2022-12-18 15:02 ` Laurent Pinchart
2022-12-18 15:00 ` [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt Laurent Pinchart
2023-01-01 3:37 ` Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Adam Ford @ 2022-12-17 18:08 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Laurent Pinchart, Lucas Stach, devicetree,
linux-kernel
dt_binding_check detects an issue with the pgc_hsiomix power
domain:
pgc: 'power-domains@17' does not match any of the regexes
This is because 'power-domains' should be 'power-domain'
Fixes: 2ae42e0c0b67 ("arm64: dts: imx8mp: add HSIO power-domains")
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 7a8ca56e48b6..19609ef0560a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -591,7 +591,7 @@ pgc_mipi_phy2: power-domain@16 {
reg = <IMX8MP_POWER_DOMAIN_MIPI_PHY2>;
};
- pgc_hsiomix: power-domains@17 {
+ pgc_hsiomix: power-domain@17 {
#power-domain-cells = <0>;
reg = <IMX8MP_POWER_DOMAIN_HSIOMIX>;
clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo
2022-12-17 18:08 ` [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo Adam Ford
@ 2022-12-18 15:02 ` Laurent Pinchart
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2022-12-18 15:02 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Lucas Stach, devicetree, linux-kernel
Hi Adam,
Thank you for the patch.
On Sat, Dec 17, 2022 at 12:08:49PM -0600, Adam Ford wrote:
> dt_binding_check detects an issue with the pgc_hsiomix power
> domain:
> pgc: 'power-domains@17' does not match any of the regexes
>
> This is because 'power-domains' should be 'power-domain'
Oops.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Fixes: 2ae42e0c0b67 ("arm64: dts: imx8mp: add HSIO power-domains")
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 7a8ca56e48b6..19609ef0560a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -591,7 +591,7 @@ pgc_mipi_phy2: power-domain@16 {
> reg = <IMX8MP_POWER_DOMAIN_MIPI_PHY2>;
> };
>
> - pgc_hsiomix: power-domains@17 {
> + pgc_hsiomix: power-domain@17 {
> #power-domain-cells = <0>;
> reg = <IMX8MP_POWER_DOMAIN_HSIOMIX>;
> clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt
2022-12-17 18:08 [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt Adam Ford
2022-12-17 18:08 ` [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo Adam Ford
@ 2022-12-18 15:00 ` Laurent Pinchart
2022-12-18 15:58 ` Adam Ford
2023-01-01 3:37 ` Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2022-12-18 15:00 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Lucas Stach, devicetree, linux-kernel
Hi Adam,
Thank you for the patch.
On Sat, Dec 17, 2022 at 12:08:48PM -0600, Adam Ford wrote:
> The GPC node references an interrupt parent, but it doesn't
> state the interrupt itself. According to the TRM, this IRQ
> is 87. This also eliminate an error detected from dt_binding_check
The interrupt isn't used by the driver as far as I can see, so I can't
test this, but the patch matches the reference manual, so
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Fixes: fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 7a6e6221f421..7a8ca56e48b6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -524,6 +524,7 @@ gpc: gpc@303a0000 {
> compatible = "fsl,imx8mp-gpc";
> reg = <0x303a0000 0x1000>;
> interrupt-parent = <&gic>;
> + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-controller;
> #interrupt-cells = <3>;
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt
2022-12-18 15:00 ` [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt Laurent Pinchart
@ 2022-12-18 15:58 ` Adam Ford
0 siblings, 0 replies; 6+ messages in thread
From: Adam Ford @ 2022-12-18 15:58 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, aford, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Lucas Stach, devicetree, linux-kernel
On Sun, Dec 18, 2022 at 9:00 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Adam,
>
> Thank you for the patch.
>
> On Sat, Dec 17, 2022 at 12:08:48PM -0600, Adam Ford wrote:
> > The GPC node references an interrupt parent, but it doesn't
> > state the interrupt itself. According to the TRM, this IRQ
> > is 87. This also eliminate an error detected from dt_binding_check
>
> The interrupt isn't used by the driver as far as I can see, so I can't
> test this, but the patch matches the reference manual, so
I don't think it changes functionality, but the other imx8m boards
have it, and 'make dtbs_check' showed it as missing.
Thanks for the review.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > Fixes: fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 7a6e6221f421..7a8ca56e48b6 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -524,6 +524,7 @@ gpc: gpc@303a0000 {
> > compatible = "fsl,imx8mp-gpc";
> > reg = <0x303a0000 0x1000>;
> > interrupt-parent = <&gic>;
> > + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-controller;
> > #interrupt-cells = <3>;
> >
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt
2022-12-17 18:08 [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt Adam Ford
2022-12-17 18:08 ` [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo Adam Ford
2022-12-18 15:00 ` [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt Laurent Pinchart
@ 2023-01-01 3:37 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2023-01-01 3:37 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Rob Herring, Krzysztof Kozlowski,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Laurent Pinchart, Lucas Stach, devicetree,
linux-kernel
On Sat, Dec 17, 2022 at 12:08:48PM -0600, Adam Ford wrote:
> The GPC node references an interrupt parent, but it doesn't
> state the interrupt itself. According to the TRM, this IRQ
> is 87. This also eliminate an error detected from dt_binding_check
>
> Fixes: fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")
> Signed-off-by: Adam Ford <aford173@gmail.com>
Applied both, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread