Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

["Ondřej Jirman" <megi@xff.cz>]

On Mon, Jan 02, 2023 at 02:51:42PM +0100, Javier Martinez Canillas wrote:
> Hello Ondřej,
> 
> [...]
>
> My goal was to have some initial support in mainline even if there could be some
> issues. IMO it is better to use upstream as a baseline and attempt to support the
> PPP incrementally.
> 
> But since you are aware of the issues and know what are the available fixes, I'll
> let you continue with the effort and take care of the patches. Hopefully there may
> be things that will be helpful, such as the binding schema patch and the collected
> tags. I can also take care of pushing the DRM bits to the drm-misc-next tree once
> you feel that those are ready to get merged.

Ok. The panel driver itself works fine with some changes in other DRM drivers.
In fact, it will not need any changes, assuming the to be proposed fixes to
dw-mipi-dsi will pass, too. So I don't have many objections against this driver
itself.

I'm not sure I should be giving reviewed-by to driver I co-wrote. :) Anyway,
I checked it again, and only issue I found was that shutdown callback tries
to disable the panel even if it may already be disabled, which will lead to
unbalanced calls to regulator_disable functions, which may produce some needless
warnings on shutdown/reboot.

So if you want to commit this driver now, go ahead. DT will need one more round.

As you say, the overall usable support for Pinephone Pro in mainline is still
way off into the future, so I agree it's not necessary to get hung up on these
issues. I can do a DT revision + add in the other suggested DRM patches, so that
there's at least a searchable public record of the remaining issues.

kind regards,
	o.

> -- 
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat
>