public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] extcon: axp288: Replace open coded acpi_dev_put()
@ 2023-01-02 20:29 Andy Shevchenko
  2023-01-10 13:14 ` Chanwoo Choi
  0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-01-02 20:29 UTC (permalink / raw)
  To: linux-kernel
  Cc: MyungJoo Ham, Chanwoo Choi, Hans de Goede, Chen-Yu Tsai,
	Andy Shevchenko

Instead of calling put_device(&adev->dev) where adev is a pointer
to an ACPI device, use specific call, i.e. acpi_dev_put().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/extcon/extcon-axp288.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index 180be768c215..a703a8315634 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -393,7 +393,7 @@ static int axp288_extcon_probe(struct platform_device *pdev)
 		adev = acpi_dev_get_first_match_dev("INT3496", NULL, -1);
 		if (adev) {
 			info->id_extcon = extcon_get_extcon_dev(acpi_dev_name(adev));
-			put_device(&adev->dev);
+			acpi_dev_put(adev);
 			if (IS_ERR(info->id_extcon))
 				return PTR_ERR(info->id_extcon);
 
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1 1/1] extcon: axp288: Replace open coded acpi_dev_put()
  2023-01-02 20:29 [PATCH v1 1/1] extcon: axp288: Replace open coded acpi_dev_put() Andy Shevchenko
@ 2023-01-10 13:14 ` Chanwoo Choi
  0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2023-01-10 13:14 UTC (permalink / raw)
  To: Andy Shevchenko, linux-kernel
  Cc: MyungJoo Ham, Chanwoo Choi, Hans de Goede, Chen-Yu Tsai

On 23. 1. 3. 05:29, Andy Shevchenko wrote:
> Instead of calling put_device(&adev->dev) where adev is a pointer
> to an ACPI device, use specific call, i.e. acpi_dev_put().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/extcon/extcon-axp288.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index 180be768c215..a703a8315634 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -393,7 +393,7 @@ static int axp288_extcon_probe(struct platform_device *pdev)
>  		adev = acpi_dev_get_first_match_dev("INT3496", NULL, -1);
>  		if (adev) {
>  			info->id_extcon = extcon_get_extcon_dev(acpi_dev_name(adev));
> -			put_device(&adev->dev);
> +			acpi_dev_put(adev);
>  			if (IS_ERR(info->id_extcon))
>  				return PTR_ERR(info->id_extcon);
>  

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-10 13:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-02 20:29 [PATCH v1 1/1] extcon: axp288: Replace open coded acpi_dev_put() Andy Shevchenko
2023-01-10 13:14 ` Chanwoo Choi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox