drivers/i2c/busses/i2c-qcom-geni.c:937 geni_i2c_probe() warn: 'gi2c->core_clk' from clk_prepare_enable() not released on lines: 896.

Dan Carpenter
2023-01-04T08:40:10Z

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 69b41ac87e4a664de78a395ff97166f0b2943210
commit: 14d02fbadb5dc1cdf66078ef8430dd1cd22bfd53 i2c: qcom-geni: add desc struct to prepare support for I2C Master Hub variant
compiler: csky-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>

New smatch warnings:
drivers/i2c/busses/i2c-qcom-geni.c:937 geni_i2c_probe() warn: 'gi2c->core_clk' from clk_prepare_enable() not released on lines: 896.

vim +937 drivers/i2c/busses/i2c-qcom-geni.c

37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 768 static int geni_i2c_probe(struct platform_device *pdev)
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 769 {
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 770 struct geni_i2c_dev *gi2c;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 771 struct resource *res;
d8703554f4dea9 Vinod Koul 2022-02-21 772 u32 proto, tx_depth, fifo_disable;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 773 int ret;
3b7d81f08a6a2b Stephen Boyd 2020-03-10 774 struct device *dev = &pdev->dev;
14d02fbadb5dc1 Neil Armstrong 2022-11-29 775 const struct geni_i2c_desc *desc = NULL;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 776
3b7d81f08a6a2b Stephen Boyd 2020-03-10 777 gi2c = devm_kzalloc(dev, sizeof(*gi2c), GFP_KERNEL);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 778 if (!gi2c)
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 779 return -ENOMEM;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 780
3b7d81f08a6a2b Stephen Boyd 2020-03-10 781 gi2c->se.dev = dev;
3b7d81f08a6a2b Stephen Boyd 2020-03-10 782 gi2c->se.wrapper = dev_get_drvdata(dev->parent);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 783 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
3b7d81f08a6a2b Stephen Boyd 2020-03-10 784 gi2c->se.base = devm_ioremap_resource(dev, res);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 785 if (IS_ERR(gi2c->se.base))
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 786 return PTR_ERR(gi2c->se.base);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 787
14d02fbadb5dc1 Neil Armstrong 2022-11-29 788 desc = device_get_match_data(&pdev->dev);
14d02fbadb5dc1 Neil Armstrong 2022-11-29 789
14d02fbadb5dc1 Neil Armstrong 2022-11-29 790 if (desc && desc->has_core_clk) {
14d02fbadb5dc1 Neil Armstrong 2022-11-29 791 gi2c->core_clk = devm_clk_get(dev, "core");
14d02fbadb5dc1 Neil Armstrong 2022-11-29 792 if (IS_ERR(gi2c->core_clk))
14d02fbadb5dc1 Neil Armstrong 2022-11-29 793 return PTR_ERR(gi2c->core_clk);
14d02fbadb5dc1 Neil Armstrong 2022-11-29 794 }
14d02fbadb5dc1 Neil Armstrong 2022-11-29 795
3b7d81f08a6a2b Stephen Boyd 2020-03-10 796 gi2c->se.clk = devm_clk_get(dev, "se");
3b7d81f08a6a2b Stephen Boyd 2020-03-10 797 if (IS_ERR(gi2c->se.clk) && !has_acpi_companion(dev))
3b7d81f08a6a2b Stephen Boyd 2020-03-10 798 return PTR_ERR(gi2c->se.clk);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 799
3b7d81f08a6a2b Stephen Boyd 2020-03-10 800 ret = device_property_read_u32(dev, "clock-frequency",
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 801 &gi2c->clk_freq_out);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 802 if (ret) {
3b7d81f08a6a2b Stephen Boyd 2020-03-10 803 dev_info(dev, "Bus frequency not specified, default to 100kHz.\n");
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 804 gi2c->clk_freq_out = KHZ(100);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 805 }
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 806
3b7d81f08a6a2b Stephen Boyd 2020-03-10 807 if (has_acpi_companion(dev))
3b7d81f08a6a2b Stephen Boyd 2020-03-10 808 ACPI_COMPANION_SET(&gi2c->adap.dev, ACPI_COMPANION(dev));
c9913ac42135cf Lee Jones 2019-06-12 809
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 810 gi2c->irq = platform_get_irq(pdev, 0);
3b7d81f08a6a2b Stephen Boyd 2020-03-10 811 if (gi2c->irq < 0)
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 812 return gi2c->irq;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 813
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 814 ret = geni_i2c_clk_map_idx(gi2c);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 815 if (ret) {
3b7d81f08a6a2b Stephen Boyd 2020-03-10 816 dev_err(dev, "Invalid clk frequency %d Hz: %d\n",
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 817 gi2c->clk_freq_out, ret);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 818 return ret;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 819 }
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 820
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 821 gi2c->adap.algo = &geni_i2c_algo;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 822 init_completion(&gi2c->done);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 823 spin_lock_init(&gi2c->lock);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 824 platform_set_drvdata(pdev, gi2c);
3b7d81f08a6a2b Stephen Boyd 2020-03-10 825 ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, 0,
3b7d81f08a6a2b Stephen Boyd 2020-03-10 826 dev_name(dev), gi2c);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 827 if (ret) {
3b7d81f08a6a2b Stephen Boyd 2020-03-10 828 dev_err(dev, "Request_irq failed:%d: err:%d\n",
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 829 gi2c->irq, ret);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 830 return ret;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 831 }
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 832 /* Disable the interrupt so that the system can enter low-power mode */
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 833 disable_irq(gi2c->irq);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 834 i2c_set_adapdata(&gi2c->adap, gi2c);
3b7d81f08a6a2b Stephen Boyd 2020-03-10 835 gi2c->adap.dev.parent = dev;
3b7d81f08a6a2b Stephen Boyd 2020-03-10 836 gi2c->adap.dev.of_node = dev->of_node;
ea1558ce149d28 Wolfram Sang 2022-08-11 837 strscpy(gi2c->adap.name, "Geni-I2C", sizeof(gi2c->adap.name));
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 838
14d02fbadb5dc1 Neil Armstrong 2022-11-29 839 ret = geni_icc_get(&gi2c->se, desc ? desc->icc_ddr : "qup-memory");
bf225ed357c65e Akash Asthana 2020-06-23 840 if (ret)
bf225ed357c65e Akash Asthana 2020-06-23 841 return ret;
bf225ed357c65e Akash Asthana 2020-06-23 842 /*
bf225ed357c65e Akash Asthana 2020-06-23 843 * Set the bus quota for core and cpu to a reasonable value for
bf225ed357c65e Akash Asthana 2020-06-23 844 * register access.
bf225ed357c65e Akash Asthana 2020-06-23 845 * Set quota for DDR based on bus speed.
bf225ed357c65e Akash Asthana 2020-06-23 846 */
bf225ed357c65e Akash Asthana 2020-06-23 847 gi2c->se.icc_paths[GENI_TO_CORE].avg_bw = GENI_DEFAULT_BW;
bf225ed357c65e Akash Asthana 2020-06-23 848 gi2c->se.icc_paths[CPU_TO_GENI].avg_bw = GENI_DEFAULT_BW;
14d02fbadb5dc1 Neil Armstrong 2022-11-29 849 if (!desc || desc->icc_ddr)
bf225ed357c65e Akash Asthana 2020-06-23 850 gi2c->se.icc_paths[GENI_TO_DDR].avg_bw = Bps_to_icc(gi2c->clk_freq_out);
bf225ed357c65e Akash Asthana 2020-06-23 851
bf225ed357c65e Akash Asthana 2020-06-23 852 ret = geni_icc_set_bw(&gi2c->se);
bf225ed357c65e Akash Asthana 2020-06-23 853 if (ret)
bf225ed357c65e Akash Asthana 2020-06-23 854 return ret;
bf225ed357c65e Akash Asthana 2020-06-23 855
14d02fbadb5dc1 Neil Armstrong 2022-11-29 856 ret = clk_prepare_enable(gi2c->core_clk);
14d02fbadb5dc1 Neil Armstrong 2022-11-29 857 if (ret)
14d02fbadb5dc1 Neil Armstrong 2022-11-29 858 return ret;
14d02fbadb5dc1 Neil Armstrong 2022-11-29 859
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 860 ret = geni_se_resources_on(&gi2c->se);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 861 if (ret) {
3b7d81f08a6a2b Stephen Boyd 2020-03-10 862 dev_err(dev, "Error turning on resources %d\n", ret);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 863 return ret;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 864 }
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 865 proto = geni_se_read_proto(&gi2c->se);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 866 if (proto != GENI_SE_I2C) {
3b7d81f08a6a2b Stephen Boyd 2020-03-10 867 dev_err(dev, "Invalid proto %d\n", proto);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 868 geni_se_resources_off(&gi2c->se);
14d02fbadb5dc1 Neil Armstrong 2022-11-29 869 clk_disable_unprepare(gi2c->core_clk);

Error handling clean up.

37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 870 return -ENXIO;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 871 }
d8703554f4dea9 Vinod Koul 2022-02-21 872
14d02fbadb5dc1 Neil Armstrong 2022-11-29 873 if (desc && desc->no_dma_support)
14d02fbadb5dc1 Neil Armstrong 2022-11-29 874 fifo_disable = false;
14d02fbadb5dc1 Neil Armstrong 2022-11-29 875 else
d8703554f4dea9 Vinod Koul 2022-02-21 876 fifo_disable = readl_relaxed(gi2c->se.base + GENI_IF_DISABLE_RO) & FIFO_IF_DISABLE;
14d02fbadb5dc1 Neil Armstrong 2022-11-29 877
d8703554f4dea9 Vinod Koul 2022-02-21 878 if (fifo_disable) {
d8703554f4dea9 Vinod Koul 2022-02-21 879 /* FIFO is disabled, so we can only use GPI DMA */
d8703554f4dea9 Vinod Koul 2022-02-21 880 gi2c->gpi_mode = true;
d8703554f4dea9 Vinod Koul 2022-02-21 881 ret = setup_gpi_dma(gi2c);
c60bd968c74749 Bjorn Andersson 2022-04-12 882 if (ret)
c60bd968c74749 Bjorn Andersson 2022-04-12 883 return dev_err_probe(dev, ret, "Failed to setup GPI DMA mode\n");

No clean up.

d8703554f4dea9 Vinod Koul 2022-02-21 884
d8703554f4dea9 Vinod Koul 2022-02-21 885 dev_dbg(dev, "Using GPI DMA mode for I2C\n");
d8703554f4dea9 Vinod Koul 2022-02-21 886 } else {
d8703554f4dea9 Vinod Koul 2022-02-21 887 gi2c->gpi_mode = false;
d8703554f4dea9 Vinod Koul 2022-02-21 888 tx_depth = geni_se_get_tx_fifo_depth(&gi2c->se);
14d02fbadb5dc1 Neil Armstrong 2022-11-29 889
14d02fbadb5dc1 Neil Armstrong 2022-11-29 890 /* I2C Master Hub Serial Elements doesn't have the HW_PARAM_0 register */
14d02fbadb5dc1 Neil Armstrong 2022-11-29 891 if (!tx_depth && desc)
14d02fbadb5dc1 Neil Armstrong 2022-11-29 892 tx_depth = desc->tx_fifo_depth;
14d02fbadb5dc1 Neil Armstrong 2022-11-29 893
14d02fbadb5dc1 Neil Armstrong 2022-11-29 894 if (!tx_depth) {
14d02fbadb5dc1 Neil Armstrong 2022-11-29 895 dev_err(dev, "Invalid TX FIFO depth\n");
14d02fbadb5dc1 Neil Armstrong 2022-11-29 896 return -EINVAL;

No clean up.

14d02fbadb5dc1 Neil Armstrong 2022-11-29 897 }
14d02fbadb5dc1 Neil Armstrong 2022-11-29 898
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 899 gi2c->tx_wm = tx_depth - 1;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 900 geni_se_init(&gi2c->se, gi2c->tx_wm, tx_depth);
d8703554f4dea9 Vinod Koul 2022-02-21 901 geni_se_config_packing(&gi2c->se, BITS_PER_BYTE,
d8703554f4dea9 Vinod Koul 2022-02-21 902 PACKING_BYTES_PW, true, true, true);
d8703554f4dea9 Vinod Koul 2022-02-21 903
d8703554f4dea9 Vinod Koul 2022-02-21 904 dev_dbg(dev, "i2c fifo/se-dma mode. fifo depth:%d\n", tx_depth);
d8703554f4dea9 Vinod Koul 2022-02-21 905 }
d8703554f4dea9 Vinod Koul 2022-02-21 906
14d02fbadb5dc1 Neil Armstrong 2022-11-29 907 clk_disable_unprepare(gi2c->core_clk);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 908 ret = geni_se_resources_off(&gi2c->se);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 909 if (ret) {
3b7d81f08a6a2b Stephen Boyd 2020-03-10 910 dev_err(dev, "Error turning off resources %d\n", ret);
d8703554f4dea9 Vinod Koul 2022-02-21 911 goto err_dma;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 912 }
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 913
bf225ed357c65e Akash Asthana 2020-06-23 914 ret = geni_icc_disable(&gi2c->se);
bf225ed357c65e Akash Asthana 2020-06-23 915 if (ret)
d8703554f4dea9 Vinod Koul 2022-02-21 916 goto err_dma;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 917
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 918 gi2c->suspended = 1;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 919 pm_runtime_set_suspended(gi2c->se.dev);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 920 pm_runtime_set_autosuspend_delay(gi2c->se.dev, I2C_AUTO_SUSPEND_DELAY);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 921 pm_runtime_use_autosuspend(gi2c->se.dev);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 922 pm_runtime_enable(gi2c->se.dev);
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 923
848bd3f3de9d44 Stephen Boyd 2018-11-02 924 ret = i2c_add_adapter(&gi2c->adap);
848bd3f3de9d44 Stephen Boyd 2018-11-02 925 if (ret) {
3b7d81f08a6a2b Stephen Boyd 2020-03-10 926 dev_err(dev, "Error adding i2c adapter %d\n", ret);
848bd3f3de9d44 Stephen Boyd 2018-11-02 927 pm_runtime_disable(gi2c->se.dev);
d8703554f4dea9 Vinod Koul 2022-02-21 928 goto err_dma;
848bd3f3de9d44 Stephen Boyd 2018-11-02 929 }
848bd3f3de9d44 Stephen Boyd 2018-11-02 930
3b7d81f08a6a2b Stephen Boyd 2020-03-10 931 dev_dbg(dev, "Geni-I2C adaptor successfully added\n");
c3c2889b8a2c9d Lee Jones 2019-06-12 932
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 933 return 0;
d8703554f4dea9 Vinod Koul 2022-02-21 934
d8703554f4dea9 Vinod Koul 2022-02-21 935 err_dma:
d8703554f4dea9 Vinod Koul 2022-02-21 936 release_gpi_dma(gi2c);
d8703554f4dea9 Vinod Koul 2022-02-21 @937 return ret;
37692de5d52353 Karthikeyan Ramasubramanian 2018-07-30 938 }

--
0-DAY CI Kernel Test Service