* [PATCH] media: atomisp: fix videobuf2 Kconfig depenendency
@ 2023-01-04 8:21 Arnd Bergmann
2023-01-04 11:15 ` Andy Shevchenko
2023-01-10 11:02 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-01-04 8:21 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab
Cc: Arnd Bergmann, Sakari Ailus, Greg Kroah-Hartman,
Andrzej Pietrasiewicz, Andy Shevchenko, linux-media,
linux-staging, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The recent conversion missed the Kconfig bit, so it can now
end up in a link error on randconfig builds:
ld.lld: error: undefined symbol: vb2_vmalloc_memops
>>> referenced by atomisp_fops.c
>>> drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a
Fixes: cb48ae89be3b ("media: atomisp: Convert to videobuf2")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/media/atomisp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
index 2c8d7fdcc5f7..c9bff98e5309 100644
--- a/drivers/staging/media/atomisp/Kconfig
+++ b/drivers/staging/media/atomisp/Kconfig
@@ -14,7 +14,7 @@ config VIDEO_ATOMISP
depends on VIDEO_DEV && INTEL_ATOMISP
depends on PMIC_OPREGION
select IOSF_MBI
- select VIDEOBUF_VMALLOC
+ select VIDEOBUF2_VMALLOC
select VIDEO_V4L2_SUBDEV_API
help
Say Y here if your platform supports Intel Atom SoC
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: atomisp: fix videobuf2 Kconfig depenendency
2023-01-04 8:21 [PATCH] media: atomisp: fix videobuf2 Kconfig depenendency Arnd Bergmann
@ 2023-01-04 11:15 ` Andy Shevchenko
2023-01-10 11:02 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-01-04 11:15 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Hans de Goede, Mauro Carvalho Chehab, Arnd Bergmann, Sakari Ailus,
Greg Kroah-Hartman, Andrzej Pietrasiewicz, linux-media,
linux-staging, linux-kernel
On Wed, Jan 04, 2023 at 09:21:36AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The recent conversion missed the Kconfig bit, so it can now
> end up in a link error on randconfig builds:
>
> ld.lld: error: undefined symbol: vb2_vmalloc_memops
> >>> referenced by atomisp_fops.c
> >>> drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a
Tested-by: Andy Shevchenko <andy@kernel.org>
> Fixes: cb48ae89be3b ("media: atomisp: Convert to videobuf2")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/media/atomisp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
> index 2c8d7fdcc5f7..c9bff98e5309 100644
> --- a/drivers/staging/media/atomisp/Kconfig
> +++ b/drivers/staging/media/atomisp/Kconfig
> @@ -14,7 +14,7 @@ config VIDEO_ATOMISP
> depends on VIDEO_DEV && INTEL_ATOMISP
> depends on PMIC_OPREGION
> select IOSF_MBI
> - select VIDEOBUF_VMALLOC
> + select VIDEOBUF2_VMALLOC
> select VIDEO_V4L2_SUBDEV_API
> help
> Say Y here if your platform supports Intel Atom SoC
> --
> 2.39.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: atomisp: fix videobuf2 Kconfig depenendency
2023-01-04 8:21 [PATCH] media: atomisp: fix videobuf2 Kconfig depenendency Arnd Bergmann
2023-01-04 11:15 ` Andy Shevchenko
@ 2023-01-10 11:02 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2023-01-10 11:02 UTC (permalink / raw)
To: Arnd Bergmann, Mauro Carvalho Chehab
Cc: Arnd Bergmann, Sakari Ailus, Greg Kroah-Hartman,
Andrzej Pietrasiewicz, Andy Shevchenko, linux-media,
linux-staging, linux-kernel
Hi,
On 1/4/23 09:21, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The recent conversion missed the Kconfig bit, so it can now
> end up in a link error on randconfig builds:
>
> ld.lld: error: undefined symbol: vb2_vmalloc_memops
>>>> referenced by atomisp_fops.c
>>>> drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a
>
> Fixes: cb48ae89be3b ("media: atomisp: Convert to videobuf2")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Mauro, can you pick this up and send it to Linus as a 6.1 fix?
Regards,
Hans
> ---
> drivers/staging/media/atomisp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
> index 2c8d7fdcc5f7..c9bff98e5309 100644
> --- a/drivers/staging/media/atomisp/Kconfig
> +++ b/drivers/staging/media/atomisp/Kconfig
> @@ -14,7 +14,7 @@ config VIDEO_ATOMISP
> depends on VIDEO_DEV && INTEL_ATOMISP
> depends on PMIC_OPREGION
> select IOSF_MBI
> - select VIDEOBUF_VMALLOC
> + select VIDEOBUF2_VMALLOC
> select VIDEO_V4L2_SUBDEV_API
> help
> Say Y here if your platform supports Intel Atom SoC
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-10 11:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-04 8:21 [PATCH] media: atomisp: fix videobuf2 Kconfig depenendency Arnd Bergmann
2023-01-04 11:15 ` Andy Shevchenko
2023-01-10 11:02 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox