From: Asutosh Das <quic_asutoshd@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
Can Guo <quic_cang@quicinc.com>
Subject: Re: [PATCH] scsi: ufs: core: fix devfreq deadlocks
Date: Wed, 4 Jan 2023 06:10:45 -0800 [thread overview]
Message-ID: <20230104141045.GB8114@asutoshd-linux1.qualcomm.com> (raw)
In-Reply-To: <85e91255-1e6f-f428-5376-08416d2107a2@acm.org>
On Tue, Jan 03 2023 at 13:45 -0800, Bart Van Assche wrote:
>On 12/22/22 02:21, Johan Hovold wrote:
>>+ /* Enable Write Booster if we have scaled up else disable it */
>>+ if (ufshcd_enable_wb_if_scaling_up(hba))
>>+ ufshcd_wb_toggle(hba, scale_up);
>
>Hi Asutosh,
>
>This patch is the second complaint about the mechanism that toggles
>the WriteBooster during clock scaling. Can this mechanism be removed
>entirely?
>
>I think this commit introduced that mechanism: 3d17b9b5ab11 ("scsi:
>ufs: Add write booster feature support"; v5.8).
>
>Thanks,
>
>Bart.
Hello Bart,
Load based toggling of WB seemed fine to me then.
I haven't thought about another method to toggle WriteBooster yet.
Let me see if I can come up with something.
IMT if you have a mechanism in mind, please let me know.
-asd
>
next prev parent reply other threads:[~2023-01-04 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 10:21 [PATCH] scsi: ufs: core: fix devfreq deadlocks Johan Hovold
2023-01-03 21:28 ` Andrew Halaney
2023-01-03 21:45 ` Bart Van Assche
2023-01-04 8:24 ` Avri Altman
2023-01-04 22:34 ` Bart Van Assche
2023-01-04 14:10 ` Asutosh Das [this message]
2023-01-04 22:31 ` Bart Van Assche
2023-01-05 7:21 ` Avri Altman
2023-01-06 2:24 ` Jinyoung CHOI
2023-01-06 14:51 ` (2) " Asutosh Das
2023-01-05 18:38 ` Bart Van Assche
2023-01-16 16:03 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104141045.GB8114@asutoshd-linux1.qualcomm.com \
--to=quic_asutoshd@quicinc.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox