From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: caleb.connolly@linaro.org, mka@chromium.org,
evgreen@chromium.org, andersson@kernel.org,
quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com,
quic_jponduru@quicinc.com, quic_subashab@quicinc.com,
elder@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next v2 0/6] net: ipa: simplify IPA interrupt handling
Date: Wed, 4 Jan 2023 11:52:27 -0600 [thread overview]
Message-ID: <20230104175233.2862874-1-elder@linaro.org> (raw)
One of the IPA's two IRQs fires when data on a suspended channel is
available (to request that the channel--or system--be resumed to
recieve the pending data). This interrupt also handles a few
conditions signaled by the embedded microcontroller.
For this "IPA interrupt", the current code requires a handler to be
dynamically registered for each interrupt condition. Any condition
that has no registered handler is quietly ignored. This design is
derived from the downstream IPA driver implementation.
There isn't any need for this complexity. Even in the downstream
code, only four of the available 30 or so IPA interrupt conditions
are ever handled. So these handlers can pretty easily just be
called directly in the main IRQ handler function.
This series simplifies the interrupt handling code by having the
small number of IPA interrupt handlers be called directly, rather
than having them be registered dynamically.
Version 2 just adds a missing forward-reference, as suggested by
Caleb.
-Alex
Alex Elder (6):
net: ipa: introduce a common microcontroller interrupt handler
net: ipa: introduce ipa_interrupt_enable()
net: ipa: enable IPA interrupt handlers separate from registration
net: ipa: register IPA interrupt handlers directly
net: ipa: kill ipa_interrupt_add()
net: ipa: don't maintain IPA interrupt handler array
drivers/net/ipa/ipa_interrupt.c | 103 ++++++++++++++------------------
drivers/net/ipa/ipa_interrupt.h | 48 +++++----------
drivers/net/ipa/ipa_power.c | 19 ++----
drivers/net/ipa/ipa_power.h | 12 ++++
drivers/net/ipa/ipa_uc.c | 21 +++++--
drivers/net/ipa/ipa_uc.h | 8 +++
6 files changed, 99 insertions(+), 112 deletions(-)
--
2.34.1
next reply other threads:[~2023-01-04 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 17:52 Alex Elder [this message]
2023-01-04 17:52 ` [PATCH net-next v2 1/6] net: ipa: introduce a common microcontroller interrupt handler Alex Elder
2023-01-04 17:52 ` [PATCH net-next v2 2/6] net: ipa: introduce ipa_interrupt_enable() Alex Elder
2023-01-04 17:52 ` [PATCH net-next v2 3/6] net: ipa: enable IPA interrupt handlers separate from registration Alex Elder
2023-01-04 17:52 ` [PATCH net-next v2 4/6] net: ipa: register IPA interrupt handlers directly Alex Elder
2023-01-04 17:52 ` [PATCH net-next v2 5/6] net: ipa: kill ipa_interrupt_add() Alex Elder
2023-01-04 17:52 ` [PATCH net-next v2 6/6] net: ipa: don't maintain IPA interrupt handler array Alex Elder
2023-01-06 6:10 ` [PATCH net-next v2 0/6] net: ipa: simplify IPA interrupt handling patchwork-bot+netdevbpf
2023-01-06 6:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104175233.2862874-1-elder@linaro.org \
--to=elder@linaro.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_avuyyuru@quicinc.com \
--cc=quic_cpratapa@quicinc.com \
--cc=quic_jponduru@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox