From: Orlando Chamberlain <orlandoch.dev@gmail.com>
To: marcan@marcan.st
Cc: asahi@lists.linux.dev, axboe@fb.com, hch@lst.de,
kbusch@kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
sven@svenpeter.dev, ushankar@purestorage.com
Subject: Re: [PATCH] nvme-pci: Add NVME_QUIRK_IDENTIFY_CNS quirk to Apple T2 controllers
Date: Wed, 4 Jan 2023 23:03:00 +1100 [thread overview]
Message-ID: <20230104230300.66b4a581@redecorated-mbp> (raw)
In-Reply-To: <20230104101641.12215-1-marcan@marcan.st>
> This mirrors the quirk added to Apple Silicon controllers in apple.c.
> These controllers do not support the Active NS ID List command and
> behave identically to the SoC version judging by existing user
> reports/syslogs, so will need the same fix. This quirk reverts
> back to NVMe 1.0 behavior and disables the broken commands.
>
> Fixes: 811f4de0344d ("nvme: avoid fallback to sequential scan due to transient issues")
> Signed-off-by: Hector Martin <marcan@marcan.st>
On T2 macbookpro16,1 with 6.2.0-rc3-00010-g69b41ac87e4a I had this in
dmesg:
nvme nvme0: 1/0/0 default/read/poll queues
nvme nvme0: Identify NS List failed (status=0xb)
And in /dev only nvme0 existed (no nvme0n1*).
This patch fixed that and /dev/nvme0n1p* existed.
Tested-by: Orlando Chamberlain <orlandoch.dev@gmail.com>
next prev parent reply other threads:[~2023-01-04 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:21 [PATCH] nvme-apple: Add NVME_QUIRK_IDENTIFY_CNS quirk to fix regression Hector Martin
2023-01-04 9:33 ` Sven Peter
2023-01-04 10:16 ` [PATCH] nvme-pci: Add NVME_QUIRK_IDENTIFY_CNS quirk to Apple T2 controllers Hector Martin
2023-01-04 12:03 ` Orlando Chamberlain [this message]
2023-01-08 18:15 ` [PATCH] nvme-apple: Add NVME_QUIRK_IDENTIFY_CNS quirk to fix regression Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104230300.66b4a581@redecorated-mbp \
--to=orlandoch.dev@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marcan@marcan.st \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox