From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A8DC4708E for ; Fri, 6 Jan 2023 00:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236180AbjAFAwJ (ORCPT ); Thu, 5 Jan 2023 19:52:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235969AbjAFAwG (ORCPT ); Thu, 5 Jan 2023 19:52:06 -0500 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62A392DC4 for ; Thu, 5 Jan 2023 16:52:04 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id C21AD20176; Fri, 6 Jan 2023 01:52:02 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CXxScuYzd18E; Fri, 6 Jan 2023 01:52:02 +0100 (CET) Received: from begin (adijon-658-1-86-31.w86-204.abo.wanadoo.fr [86.204.233.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 157DA20172; Fri, 6 Jan 2023 01:52:02 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pDaxl-000k0r-25; Fri, 06 Jan 2023 01:52:01 +0100 Date: Fri, 6 Jan 2023 01:52:01 +0100 From: Samuel Thibault To: Yang Li Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH -next] speakup: Fix warning comparing pointer to 0 Message-ID: <20230106005201.h3ikdaisqgjupavc@begin> Mail-Followup-To: Samuel Thibault , Yang Li , w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20230106004114.72589-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230106004114.72589-1-yang.lee@linux.alibaba.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yang Li, le ven. 06 janv. 2023 08:41:14 +0800, a ecrit: > ./drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing pointer to 0 > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3636 > Reported-by: Abaci Robot > Signed-off-by: Yang Li Reviewed-by: Samuel Thibault > --- > drivers/accessibility/speakup/utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h > index 4ce9a12f7664..db00c962f8e2 100644 > --- a/drivers/accessibility/speakup/utils.h > +++ b/drivers/accessibility/speakup/utils.h > @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name) > else > snprintf(filename, sizeof(filename), "%s", name); > infile = fopen(filename, "r"); > - if (infile == 0) { > + if (!infile) { > fprintf(stderr, "can't open %s\n", filename); > exit(1); > } > -- > 2.20.1.7.g153144c > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.