From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Linux CGroups <cgroups@vger.kernel.org>,
Linux Documentation <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>, Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Shakeel Butt <shakeelb@google.com>,
Bagas Sanjaya <bagasdotme@gmail.com>
Subject: [PATCH] docs: cgroup-v1: wrap charge moving deprecation in warning block
Date: Fri, 6 Jan 2023 10:48:37 +0700 [thread overview]
Message-ID: <20230106034836.23708-1-bagasdotme@gmail.com> (raw)
Commit 4ddb1a2aa1a3c4 ("docs: cgroup-v1: wrap remaining admonitions in
admonition blocks") in cgroups tree states that it also wraps charge
moving deprecation notice in admonition block (specifically warning).
However, the notice isn't in cgroups tree when the v2 of formatting
improv series [1] is submitted (and then applied), but rather in mm tree
instead.
Wrap the notice to fulfill the intention of referred commit.
Link: https://lore.kernel.org/linux-doc/20230105131633.553574-1-bagasdotme@gmail.com/ # [1]
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Documentation/admin-guide/cgroup-v1/memory.rst | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst
index 258e45cc3b2db1..b73eb174735556 100644
--- a/Documentation/admin-guide/cgroup-v1/memory.rst
+++ b/Documentation/admin-guide/cgroup-v1/memory.rst
@@ -722,12 +722,14 @@ NOTE2:
8. Move charges at task migration (DEPRECATED!)
===============================================
-THIS IS DEPRECATED!
+.. warning::
-It's expensive and unreliable! It's better practice to launch workload
-tasks directly from inside their target cgroup. Use dedicated workload
-cgroups to allow fine-grained policy adjustments without having to
-move physical pages between control domains.
+ THIS IS DEPRECATED!
+
+ It's expensive and unreliable! It's better practice to launch workload
+ tasks directly from inside their target cgroup. Use dedicated workload
+ cgroups to allow fine-grained policy adjustments without having to
+ move physical pages between control domains.
Users can move charges associated with a task along with task migration, that
is, uncharge task's pages from the old cgroup and charge them to the new cgroup.
base-commit: dd5c3ba990ae67409bc058051efcd40c3689d01d
--
An old man doll... just what I always wanted! - Clara
next reply other threads:[~2023-01-06 3:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 3:48 Bagas Sanjaya [this message]
2023-01-20 8:20 ` [PATCH] docs: cgroup-v1: wrap charge moving deprecation in warning block Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106034836.23708-1-bagasdotme@gmail.com \
--to=bagasdotme@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox