From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: huyue2@coolpad.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [RFC PATCH 5/6] erofs: implement .mmap for page cache sharing
Date: Fri, 6 Jan 2023 20:53:29 +0800 [thread overview]
Message-ID: <20230106125330.55529-6-jefflexu@linux.alibaba.com> (raw)
In-Reply-To: <20230106125330.55529-1-jefflexu@linux.alibaba.com>
In mmap(2), replace vma->vm_file with the anonymous file associated with
the blob, so that the vma will be linked to the address_space of the
blob.
One thing worth noting is that, we return error early in mmap(2) if
users attempt to map beyond the file size. Normally filesystems won't
restrict this in mmap(2). The checking is done in the fault handler,
and SIGBUS will be signaled to users if they actually attempt to access
the area beyond the end of the file. However since vma->vm_file has
been changed to the anonymous file in mmap(2), we can no way derive the
file size of the original file. As file size is immutable in ro
filesystem, let's fail early in mmap(2) in this case.
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
---
fs/erofs/fscache.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 1f2a42dd1590..98341d4d9c0d 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -379,9 +379,46 @@ static ssize_t erofs_fscache_share_file_read_iter(struct kiocb *iocb,
return already_read ? already_read : ret;
}
+static const struct vm_operations_struct erofs_fscache_share_file_vm_ops = {
+ .fault = filemap_fault,
+};
+
+static int erofs_fscache_share_file_mmap(struct file *file,
+ struct vm_area_struct *vma)
+{
+ struct inode *inode = file_inode(file);
+ /* since page cache sharing is enabled only when i_size <= chunk_size */
+ struct erofs_map_blocks map = {}; /* .m_la = 0 */
+ struct erofs_map_dev mdev;
+ int ret;
+
+ if ((vma->vm_flags & VM_SHARED) && (vma->vm_flags & VM_MAYWRITE))
+ return -EINVAL;
+
+ ret = erofs_map_blocks(inode, &map, EROFS_GET_BLOCKS_RAW);
+ if (ret)
+ return ret;
+
+ mdev = (struct erofs_map_dev) {
+ .m_deviceid = map.m_deviceid,
+ .m_pa = map.m_pa,
+ };
+ ret = erofs_map_dev(inode->i_sb, &mdev);
+ if (ret)
+ return ret;
+
+ vma_set_file(vma, mdev.m_fscache->file);
+ vma->vm_pgoff = (mdev.m_pa >> PAGE_SHIFT) + vma->vm_pgoff;
+ vma->vm_ops = &erofs_fscache_share_file_vm_ops;
+
+ file_accessed(file);
+ return 0;
+}
+
const struct file_operations erofs_fscache_share_file_fops = {
.llseek = generic_file_llseek,
.read_iter = erofs_fscache_share_file_read_iter,
+ .mmap = erofs_fscache_share_file_mmap,
};
static void erofs_fscache_domain_put(struct erofs_domain *domain)
--
2.19.1.6.gb485710b
next prev parent reply other threads:[~2023-01-06 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 12:53 [RFC PATCH 0/6] erofs: support page cache sharing between EROFS images in fscache mode Jingbo Xu
2023-01-06 12:53 ` [RFC PATCH 1/6] erofs: remove unused device mapping in the meta routine Jingbo Xu
2023-01-06 12:53 ` [RFC PATCH 2/6] erofs: unify anonymous inodes for blob Jingbo Xu
2023-01-06 12:53 ` [RFC PATCH 3/6] erofs: alloc anonymous file for blob in share domain mode Jingbo Xu
2023-01-06 12:53 ` [RFC PATCH 4/6] erofs: implement .read_iter for page cache sharing Jingbo Xu
2023-01-06 12:53 ` Jingbo Xu [this message]
2023-01-06 12:53 ` [RFC PATCH 6/6] erofs: enable page cache sharing in fscache mode Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106125330.55529-6-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).