From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C3F8C53210 for ; Sun, 8 Jan 2023 17:07:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233108AbjAHRHV (ORCPT ); Sun, 8 Jan 2023 12:07:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjAHRHS (ORCPT ); Sun, 8 Jan 2023 12:07:18 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C315795BB for ; Sun, 8 Jan 2023 09:07:17 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 2F1CE68AA6; Sun, 8 Jan 2023 18:07:15 +0100 (CET) Date: Sun, 8 Jan 2023 18:07:14 +0100 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv3 08/12] dmapool: consolidate page initialization Message-ID: <20230108170714.GC19739@lst.de> References: <20230103191551.3254778-1-kbusch@meta.com> <20230103191551.3254778-9-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103191551.3254778-9-kbusch@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2023 at 11:15:47AM -0800, Keith Busch wrote: > From: Keith Busch > > Various fields of the dma pool are set in different places. Move it all > to one function. > > Signed-off-by: Keith Busch Looks good: Reviewed-by: Christoph Hellwig