From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D4BEC54EBE for ; Sun, 8 Jan 2023 18:02:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233065AbjAHSCQ (ORCPT ); Sun, 8 Jan 2023 13:02:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231442AbjAHSCN (ORCPT ); Sun, 8 Jan 2023 13:02:13 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B270FAD1; Sun, 8 Jan 2023 10:02:13 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 9224B68AA6; Sun, 8 Jan 2023 19:02:09 +0100 (CET) Date: Sun, 8 Jan 2023 19:02:09 +0100 From: Christoph Hellwig To: Kemeng Shi Cc: axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de, john.garry@huawei.com, jack@suse.cz Subject: Re: [PATCH v2 06/13] blk-mq: remove unncessary error count and flush in blk_mq_plug_issue_direct Message-ID: <20230108180209.GE23466@lst.de> References: <20230104142259.2673013-1-shikemeng@huaweicloud.com> <20230104142259.2673013-7-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104142259.2673013-7-shikemeng@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm really confused by this. Why do we need the extra commit anyway if the errored command has never made it to the device?