From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6311CC53210 for ; Sun, 8 Jan 2023 18:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233627AbjAHSDK (ORCPT ); Sun, 8 Jan 2023 13:03:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231410AbjAHSDH (ORCPT ); Sun, 8 Jan 2023 13:03:07 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B176FCCF; Sun, 8 Jan 2023 10:03:03 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 31BBB68AA6; Sun, 8 Jan 2023 19:03:01 +0100 (CET) Date: Sun, 8 Jan 2023 19:03:01 +0100 From: Christoph Hellwig To: Kemeng Shi Cc: axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de, john.garry@huawei.com, jack@suse.cz Subject: Re: [PATCH v2 07/13] blk-mq: remove error count and unncessary flush in blk_mq_try_issue_list_directly Message-ID: <20230108180300.GF23466@lst.de> References: <20230104142259.2673013-1-shikemeng@huaweicloud.com> <20230104142259.2673013-8-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104142259.2673013-8-shikemeng@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Similar comment as for the previous patch, just complicated by the excursion to blk_mq_request_bypass_insert.